Skip to content

Commit fa97d28

Browse files
authored
Drop build_web_compilers (#739)
Not needed Speeds up build and test...a LOT
1 parent 4a1a533 commit fa97d28

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.travis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,17 @@ jobs:
3737
env: PKGS="_test_yaml checked_yaml example json_serializable"
3838
script: tool/travis.sh test_0
3939
- stage: unit_test
40-
name: "SDK: 2.7.0; PKG: json_serializable; TASKS: `pub run build_runner test --delete-conflicting-outputs -- -p chrome`"
40+
name: "SDK: 2.7.0; PKG: json_serializable; TASKS: `pub run test -p chrome`"
4141
dart: "2.7.0"
4242
os: linux
4343
env: PKGS="json_serializable"
44-
script: tool/travis.sh command
44+
script: tool/travis.sh test_2
4545
- stage: unit_test
46-
name: "SDK: dev; PKG: json_serializable; TASKS: `pub run build_runner test --delete-conflicting-outputs -- -p chrome`"
46+
name: "SDK: dev; PKG: json_serializable; TASKS: `pub run test -p chrome`"
4747
dart: dev
4848
os: linux
4949
env: PKGS="json_serializable"
50-
script: tool/travis.sh command
50+
script: tool/travis.sh test_2
5151
- stage: ensure_build
5252
name: "SDK: 2.7.0; PKGS: _test_yaml, checked_yaml, example, json_serializable; TASKS: `pub run test --run-skipped -t presubmit-only test/ensure_build_test.dart`"
5353
dart: "2.7.0"

json_serializable/mono_pkg.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ stages:
1414
dart: [2.7.0]
1515
- unit_test:
1616
- test
17-
- command: pub run build_runner test --delete-conflicting-outputs -- -p chrome
17+
- test: -p chrome
1818
- ensure_build:
1919
- test: --run-skipped -t presubmit-only test/ensure_build_test.dart
2020

json_serializable/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ dependencies:
2424
dev_dependencies:
2525
build_runner: ^1.0.0
2626
build_verify: ^1.1.0
27-
build_web_compilers: '>=1.0.0 <3.0.0'
2827
collection: ^1.14.0
2928
dart_style: ^1.2.0
3029
logging: ^0.11.3+1

tool/travis.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ for PKG in ${PKGS}; do
5858
echo
5959
echo -e "\033[1mPKG: ${PKG}; TASK: ${TASK}\033[22m"
6060
case ${TASK} in
61-
command)
62-
echo 'pub run build_runner test --delete-conflicting-outputs -- -p chrome'
63-
pub run build_runner test --delete-conflicting-outputs -- -p chrome || EXIT_CODE=$?
64-
;;
6561
dartanalyzer_0)
6662
echo 'dartanalyzer --fatal-warnings --fatal-infos .'
6763
dartanalyzer --fatal-warnings --fatal-infos . || EXIT_CODE=$?
@@ -82,6 +78,10 @@ for PKG in ${PKGS}; do
8278
echo 'pub run test --run-skipped -t presubmit-only test/ensure_build_test.dart'
8379
pub run test --run-skipped -t presubmit-only test/ensure_build_test.dart || EXIT_CODE=$?
8480
;;
81+
test_2)
82+
echo 'pub run test -p chrome'
83+
pub run test -p chrome || EXIT_CODE=$?
84+
;;
8585
*)
8686
echo -e "\033[31mUnknown TASK '${TASK}' - TERMINATING JOB\033[0m"
8787
exit 64

0 commit comments

Comments
 (0)