refactor, consistency, add test to ensure we don't need additional type check

Author: shwoodard

request.go

@@ -253,11 +253,7 @@ func unmarshalNode(data *Node, model reflect.Value, included *map[string]*Node)
 				break
 			}
 
-			// As a final catch-all, ensure types line up to avoid a runtime panic.
-			if fieldValue.Kind() != value.Kind() {
-				return ErrInvalidType
-			}
-			assignValue(fieldValue, value)
+			assign(fieldValue, value)
 		} else if annotation == annotationRelation {
 			isSlice := fieldValue.Type().Kind() == reflect.Slice
 
@@ -355,10 +351,11 @@ func assign(field, value reflect.Value) {
 		// initialize pointer so it's value
 		// can be set by assignValue
 		field.Set(reflect.New(field.Type().Elem()))
-		assignValue(field.Elem(), value)
-	} else {
-		assignValue(field, value)
+		field = field.Elem()
+
 	}
+
+	assignValue(field, value)
 }
 
 // assign assigns the specified value to the field,

request_test.go

@@ -822,6 +822,38 @@ func TestUnmarshalCustomTypeAttributes(t *testing.T) {
 	}
 }
 
+func TestUnmarshalCustomTypeAttributes_ErrInvalidType(t *testing.T) {
+	data := map[string]interface{}{
+		"data": map[string]interface{}{
+			"type": "customtypes",
+			"id":   "1",
+			"attributes": map[string]interface{}{
+				"int":        "bad",
+				"intptr":     5,
+				"intptrnull": nil,
+
+				"float":  1.5,
+				"string": "Test",
+			},
+		},
+	}
+	payload, err := json.Marshal(data)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	// Parse JSON API payload
+	customAttributeTypes := new(CustomAttributeTypes)
+	err = UnmarshalPayload(bytes.NewReader(payload), customAttributeTypes)
+	if err == nil {
+		t.Fatal("Expected an error unmarshalling the payload due to type mismatch, got none")
+	}
+
+	if err != ErrInvalidType {
+		t.Fatalf("Expected error to be %v, was %v", ErrInvalidType, err)
+	}
+}
+
 func samplePayloadWithoutIncluded() map[string]interface{} {
 	return map[string]interface{}{
 		"data": map[string]interface{}{