Skip to content

Commit 0ecced5

Browse files
authored
Fix warning (#653)
* avoid unused var warning * avoid unused var warning * avoid sign/unsigned compare warning
1 parent 3094c2a commit 0ecced5

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

core/desugarer.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,9 +355,8 @@ class Desugarer {
355355
UStringStream ss;
356356
ss << U"$outer_super_index" << (counter++);
357357
const Identifier *super_var = desugarer->id(ss.str());
358-
AST *index = super_index->index;
359358
// Desugaring of expr should already have occurred.
360-
assert(index != nullptr);
359+
assert(super_index->index != nullptr);
361360
// Re-use super_index since we're replacing it here.
362361
superVars.emplace_back(super_var, super_index);
363362
expr = alloc.make<Var>(expr->location, expr->openFodder, super_var);
@@ -405,7 +404,7 @@ class Desugarer {
405404
return super_vars;
406405
}
407406

408-
AST* makeArrayComprehension(ArrayComprehension *ast, unsigned obj_level) {
407+
AST* makeArrayComprehension(ArrayComprehension *ast) {
409408
int n = ast->specs.size();
410409
AST *zero = make<LiteralNumber>(E, EF, "0.0");
411410
AST *one = make<LiteralNumber>(E, EF, "1.0");
@@ -698,7 +697,7 @@ class Desugarer {
698697
desugar(spec.expr, obj_level);
699698
desugar(ast->body, obj_level + 1);
700699

701-
ast_ = makeArrayComprehension(ast, obj_level);
700+
ast_ = makeArrayComprehension(ast);
702701

703702
} else if (auto *ast = dynamic_cast<Assert *>(ast_)) {
704703
desugar(ast->cond, obj_level);

core/vm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1435,7 +1435,7 @@ class Interpreter {
14351435
ss << "substr third parameter should be greater than zero, got " << len;
14361436
throw makeError(loc, ss.str());
14371437
}
1438-
if (from > str->value.size()) {
1438+
if (static_cast<unsigned long>(from) > str->value.size()) {
14391439
scratch = makeString(UString());
14401440
return nullptr;
14411441
}

0 commit comments

Comments
 (0)