Skip to content

Commit 641f66f

Browse files
dmuir-gsparkprime
authored andcommitted
Refactor jsonnet desugaring to avoid stack overflow.
Default thread stacks on Windows are 1Mb and on Macos are 512Kb (except for the main thread which is 8Mb) and we've been seeing stack overflows on these platforms. It appears that recursively calling desugar consumes over 17Kb of stack, so the recursion doesn't have to go very deep before it overflows the stack. This refactoring shrinks the stack usage and lets our jsonnet run on Mac & Windows.
1 parent a0876b3 commit 641f66f

File tree

1 file changed

+274
-259
lines changed

1 file changed

+274
-259
lines changed

0 commit comments

Comments
 (0)