Skip to content

Commit e359e46

Browse files
fix RapidYAML build errors when using system provided json.hpp
When building with bundled JSON and bundled RapidYAML, the build works. However, when building with system-provided JSON and bundled RapidYAML, the build fails due to many things not being defined. It seems these are supposed to come from the standard <charconv> header, but RapidYAML 0.5.0 release erroneously strips that include in its single-file amalgamation. See RapidYAML issue biojppm/rapidyaml#364 (comment)
1 parent 955ffe6 commit e359e46

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

core/vm.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ limitations under the License.
2121
#include <set>
2222
#include <string>
2323

24+
// charconv is because the RapidYAML 0.5.0 release has a bug in the single-header build.
25+
// https://github.com/biojppm/rapidyaml/issues/364#issuecomment-1536625415
26+
#include <charconv>
27+
2428
#include "desugarer.h"
2529
#include "json.h"
2630
#include <nlohmann/json.hpp>

third_party/rapidyaml/rapidyaml.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
1+
// charconv is because the 0.5.0 release has a bug in the single-header build.
2+
// https://github.com/biojppm/rapidyaml/issues/364#issuecomment-1536625415
3+
#include <charconv>
4+
15
#define RYML_SINGLE_HDR_DEFINE_NOW
26
#include "ryml_all.hpp"

0 commit comments

Comments
 (0)