chore: clean up and update Bazel build files

Significant changes here:
- The WORKSPACE file is removed. Bazel disables WORKSPACE by default
  anyway in Bazel 8, and bzlmod has been available to use for several
  versions before that.

- Update rules_python module. Remove the custom Python toolchain
  infrastructure which is only used to find a Python C header to
  include, instead use @rules_python//python/cc:current_py_cc_headers.

- Make build targets private by default. Explicitly make public just
  the ones that are actually public interface (the jsonnet and
  jsonnetfmt command line tools, the C, C++ and Python libraries).

- Keep internal headers private.

Author: johnbartholomew

MODULE.bazel

@@ -3,13 +3,5 @@ module(
     version = "0.21.0-rc2",
 )
 
-bazel_dep(name = "googletest", version = "1.11.0", repo_name = "com_google_googletest")
-bazel_dep(name = "rules_python", version = "0.40.0")
-
-build_defs = use_extension("//tools/build_defs:extensions.bzl", "build_defs")
-use_repo(
-    build_defs,
-    "default_python3_headers",
-)
-
-register_toolchains("//platform_defs:default_python3_toolchain")
+bazel_dep(name = "googletest", version = "1.16.0")
+bazel_dep(name = "rules_python", version = "1.2.0")

MODULE.bazel.lock

@@ -1,4 +1,4 @@
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 cc_library(
     name = "utils",
@@ -10,6 +10,7 @@ cc_library(
 cc_binary(
     name = "jsonnet",
     srcs = ["jsonnet.cpp"],
+    visibility = ["//visibility:public"],
     deps = [
         ":utils",
         "//core:libjsonnet",
@@ -19,6 +20,7 @@ cc_binary(
 cc_binary(
     name = "jsonnetfmt",
     srcs = ["jsonnetfmt.cpp"],
+    visibility = ["//visibility:public"],
     deps = [
         ":utils",
         "//core:libjsonnet",

WORKSPACE

@@ -1,45 +1,46 @@
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 cc_library(
     name = "libjsonnet",
     srcs = [
-        "desugarer.cpp",
-        "formatter.cpp",
-        "lexer.cpp",
-        "libjsonnet.cpp",
-        "parser.cpp",
-        "pass.cpp",
-        "path_utils.cpp",
-        "static_analysis.cpp",
-        "string_utils.cpp",
-        "vm.cpp",
-    ],
-    hdrs = [
         "ast.h",
+        "desugarer.cpp",
         "desugarer.h",
+        "formatter.cpp",
         "formatter.h",
         "json.h",
+        "lexer.cpp",
         "lexer.h",
+        "libjsonnet.cpp",
+        "parser.cpp",
         "parser.h",
+        "pass.cpp",
         "pass.h",
+        "path_utils.cpp",
         "path_utils.h",
         "state.h",
+        "static_analysis.cpp",
         "static_analysis.h",
         "static_error.h",
+        "string_utils.cpp",
         "string_utils.h",
         "unicode.h",
+        "vm.cpp",
         "vm.h",
     ],
-    includes = ["."],
-    linkopts = ["-lm"],
-    deps = [
-        "//include:libjsonnet",
-        "//include:libjsonnet_fmt",
+    copts = ["-I."],
+    implementation_deps = [
         "//stdlib:std",
         "//third_party/json",
         "//third_party/md5:libmd5",
         "//third_party/rapidyaml:ryml",
     ],
+    linkopts = ["-lm"],
+    visibility = ["//visibility:public"],
+    deps = [
+        "//include:libjsonnet",
+        "//include:libjsonnet_fmt",
+    ],
 )
 
 cc_test(
@@ -48,7 +49,7 @@ cc_test(
     deps = [
         ":libjsonnet",
         # Note: On Ubuntu, apt-get install libgtest-dev google-mock
-        "@com_google_googletest//:gtest_main",
+        "@googletest//:gtest_main",
     ],
 )
 
@@ -57,7 +58,7 @@ cc_test(
     srcs = ["parser_test.cpp"],
     deps = [
         ":libjsonnet",
-        "@com_google_googletest//:gtest_main",
+        "@googletest//:gtest_main",
     ],
 )
 
@@ -66,7 +67,7 @@ cc_test(
     srcs = ["libjsonnet_test.cpp"],
     deps = [
         ":libjsonnet",
-        "@com_google_googletest//:gtest_main",
+        "@googletest//:gtest_main",
     ],
 )
 
@@ -75,6 +76,6 @@ cc_test(
     srcs = ["unicode_test.cpp"],
     deps = [
         ":libjsonnet",
-        "@com_google_googletest//:gtest_main",
+        "@googletest//:gtest_main",
     ],
 )

cmd/BUILD

@@ -1,8 +1,9 @@
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 cc_library(
     name = "libjsonnet++",
     srcs = ["libjsonnet++.cpp"],
+    visibility = ["//visibility:public"],
     deps = [
         "//core:libjsonnet",
         "//include:libjsonnet++",
@@ -15,6 +16,6 @@ cc_test(
     data = ["//cpp/testdata"],
     deps = [
         ":libjsonnet++",
-        "@com_google_googletest//:gtest_main",
+        "@googletest//:gtest_main",
     ],
 )

core/BUILD

@@ -1,19 +1,23 @@
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 cc_library(
     name = "libjsonnet",
     hdrs = ["libjsonnet.h"],
     includes = ["."],
+    visibility = ["//core:__pkg__"],
 )
 
 cc_library(
     name = "libjsonnet_fmt",
     hdrs = ["libjsonnet_fmt.h"],
     includes = ["."],
+    visibility = ["//core:__pkg__"],
 )
 
 cc_library(
     name = "libjsonnet++",
     hdrs = ["libjsonnet++.h"],
     includes = ["."],
+    visibility = ["//cpp:__pkg__"],
+    deps = ["//include:libjsonnet"],
 )

cpp/BUILD

@@ -1,5 +1,7 @@
 load("@rules_python//python:defs.bzl", "py_runtime", "py_runtime_pair")
 
+package(default_visibility = ["//visibility:private"])
+
 py_runtime(
     name = "python3",
     interpreter_path = "/usr/bin/python3",

include/BUILD

@@ -1,12 +1,14 @@
 load("@rules_python//python:defs.bzl", "py_library", "py_test")
 
+package(default_visibility = ["//visibility:private"])
+
 cc_binary(
     name = "_jsonnet.so",
     srcs = ["_jsonnet.c"],
     linkshared = 1,
     deps = [
         "//core:libjsonnet",
-        "@default_python3_headers//:headers",
+        "@rules_python//python/cc:current_py_cc_headers",
     ],
 )
 
@@ -20,6 +22,7 @@ py_library(
 
 py_test(
     name = "_jsonnet_test",
+    size = "small",
     srcs = ["_jsonnet_test.py"],
     data = [
         "testdata/basic_check.jsonnet",

platform_defs/BUILD

@@ -1,4 +1,4 @@
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = ["//visibility:private"])
 
 filegroup(
     name = "stdlib",
@@ -7,10 +7,10 @@ filegroup(
 
 cc_library(
     name = "std",
-    srcs = [":gen-std-jsonnet-h"],
-    hdrs = ["std.jsonnet.h"],
     includes = ["."],
     linkstatic = 1,
+    textual_hdrs = [":gen-std-jsonnet-h"],
+    visibility = ["//core:__pkg__"],
 )
 
 genrule(