Skip to content

Commit fe3ce9d

Browse files
authored
Change com_google_googletest to a non-dev dependency (#1090)
I had to patch the MODULE.bazel file as part of publishing to BCR (bazelbuild/bazel-central-registry#667), as some targets failed to build when googletest was marked as a dev dependency. I think it would be possible to get around this by limiting which parts of this repo are built by the BCR presubmit checks. Making googletest a normal dependency seems like the better option, as it will allow the presubmit checks to be more thorough.
1 parent 14f5d8e commit fe3ce9d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

MODULE.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
module(name = "jsonnet", version = "0.0.0")
22

3+
bazel_dep(name = "googletest", version = "1.11.0", repo_name = "com_google_googletest")
4+
35
build_defs = use_extension("//tools/build_defs:extensions.bzl", "build_defs")
46
use_repo(
57
build_defs,
@@ -8,7 +10,3 @@ use_repo(
810
)
911

1012
register_toolchains("//platform_defs:default_python3_toolchain")
11-
12-
# Dev dependencies
13-
14-
bazel_dep(name = "googletest", version = "1.11.0", repo_name = "com_google_googletest", dev_dependency = True)

0 commit comments

Comments
 (0)