Make uint8_t -> char conversion explicit in std::string ctor

georgthegreat · vitalybuka · commit 83a15478a47d · 2021-07-20T21:37:08.000-07:00
diff --git a/src/binary_format.cc b/src/binary_format.cc
@@ -19,7 +19,7 @@ namespace protobuf_mutator {
 using protobuf::Message;
 
 bool ParseBinaryMessage(const uint8_t* data, size_t size, Message* output) {
-  return ParseBinaryMessage({data, data + size}, output);
+  return ParseBinaryMessage({reinterpret_cast<const char*>(data), size}, output);
 }
 
 bool ParseBinaryMessage(const std::string& data, protobuf::Message* output) {
diff --git a/src/text_format.cc b/src/text_format.cc
@@ -22,7 +22,7 @@ using protobuf::Message;
 using protobuf::TextFormat;
 
 bool ParseTextMessage(const uint8_t* data, size_t size, Message* output) {
-  return ParseTextMessage({data, data + size}, output);
+  return ParseTextMessage({reinterpret_cast<const char*>(data), size}, output);
 }
 
 bool ParseTextMessage(const std::string& data, protobuf::Message* output) {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ namespace protobuf_mutator {`
`19`	`19`	`using protobuf::Message;`
`20`	`20`
`21`	`21`	`bool ParseBinaryMessage(const uint8_t* data, size_t size, Message* output) {`
`22`		`- return ParseBinaryMessage({data, data + size}, output);`
	`22`	`+ return ParseBinaryMessage({reinterpret_cast<const char*>(data), size}, output);`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`bool ParseBinaryMessage(const std::string& data, protobuf::Message* output) {`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ using protobuf::Message;`
`22`	`22`	`using protobuf::TextFormat;`
`23`	`23`
`24`	`24`	`bool ParseTextMessage(const uint8_t* data, size_t size, Message* output) {`
`25`		`- return ParseTextMessage({data, data + size}, output);`
	`25`	`+ return ParseTextMessage({reinterpret_cast<const char*>(data), size}, output);`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`bool ParseTextMessage(const std::string& data, protobuf::Message* output) {`