Skip to content

Commit 8688e95

Browse files
tcyameterstick-copybara
authored andcommitted
Fix some lint issues.
PiperOrigin-RevId: 812997263
1 parent 92840dd commit 8688e95

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

metrics.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1404,7 +1404,7 @@ def get_sql_and_with_clause(self, table, split_by, global_filter, indexes,
14041404
children_sql_copy = copy.deepcopy(children_sql)
14051405
incompatible_sqls = sql.Datasources()
14061406
child_table_aliases = []
1407-
for i, child_sql in enumerate(children_sql):
1407+
for child_sql in children_sql:
14081408
child_table_aliases.append(
14091409
incompatible_sqls.merge(
14101410
sql.Datasource(child_sql, 'MetricListChildTable')
@@ -1803,6 +1803,7 @@ def get_sql_and_with_clause(self, table, split_by, global_filter, indexes,
18031803
indexes, local_filter, with_data)
18041804

18051805
def get_sql_columns(self, local_filter):
1806+
del local_filter # unused
18061807
raise ValueError('get_sql_columns is not implemented for %s.' % type(self))
18071808

18081809

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "meterstick"
3-
version = "1.5.7"
3+
version = "1.5.8"
44
authors = [
55
{ name="Xunmo Yang", email="xunmo@google.com" },
66
{ name="Dennis Sun", email="dlsun@google.com" },

sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def nth_fn_default(
218218
raise NotImplementedError('Nth value is not implemented.') from e
219219

220220

221-
def uniform_mapping_fn_not_implemented(c):
221+
def uniform_mapping_fn_not_implemented(_):
222222
raise NotImplementedError('Uniform mapping is not implemented.')
223223

224224

utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ def get_equivalent_metric_tree(m, df=None, prefix=''):
538538
return res
539539
if not m.get_equivalent(*m.get_auxiliary_cols()):
540540
return m
541-
equiv, df = get_equivalent_metric(m, df, prefix)
541+
equiv, _ = get_equivalent_metric(m, df, prefix)
542542
return equiv
543543

544544

0 commit comments

Comments
 (0)