Skip to content

Commit f1665cd

Browse files
tcyameterstick-copybara
authored andcommitted
Fixed a bug in display that experiment id gets dropped when it's 0.
PiperOrigin-RevId: 771193952
1 parent 8451ab4 commit f1665cd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

confidence_interval_display.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ def dimension_formatter(x,
442442
d = []
443443
if description:
444444
d.append(span(description, 'ci-display-description-text'))
445-
if expr_id:
445+
if expr_id is not None:
446446
d.append(span(expr_id, 'ci-display-experiment-id'))
447447
if slice_info:
448448
d.append(span(slice_info, 'ci-display-dimension'))

operations_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1355,21 +1355,21 @@ def test_display_change(self):
13551355
df = pd.DataFrame({
13561356
'x': [1, 100, 2, 100, 3, 100],
13571357
'cookie': [1, 2, 3, 1, 2, 3],
1358-
'grp': ['A', 'B'] * 3,
1358+
'grp': [1, 0] * 3,
13591359
})
1360-
change = metrics.Sum('x') | operations.PercentChange('grp', 'A')
1360+
change = metrics.Sum('x') | operations.PercentChange('grp', 1)
13611361
m = operations.Jackknife('cookie', change, 0.9)
13621362
res = m.compute_on(df)
13631363
output = res.display(return_formatted_df=True)
13641364
expected = pd.DataFrame(
13651365
{
13661366
'Dimensions': [
13671367
(
1368-
'<div><div><span class="ci-display-experiment-id">A</span>'
1368+
'<div><div><span class="ci-display-experiment-id">1</span>'
13691369
'</div></div>'
13701370
),
13711371
(
1372-
'<div><div><span class="ci-display-experiment-id">B</span>'
1372+
'<div><div><span class="ci-display-experiment-id">0</span>'
13731373
'</div></div>'
13741374
),
13751375
],

0 commit comments

Comments
 (0)