Skip to content

Commit 441adea

Browse files
authored
Rename sparse_bucket_generator to generate_vocab (#226)
Also removed dangling references to files that do not exist, and updated documentation accordingly.
1 parent 08ba9aa commit 441adea

File tree

5 files changed

+3
-7
lines changed

5 files changed

+3
-7
lines changed

compiler_opt/rl/inlining/config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
@gin.configurable()
2626
def get_inlining_signature_spec():
2727
"""Returns (time_step_spec, action_spec) for LLVM inlining."""
28-
# LINT.IfChange
2928
observation_spec = dict(
3029
(key, tf.TensorSpec(dtype=tf.int64, shape=(), name=key)) for key in (
3130
# Base features
@@ -75,7 +74,6 @@ def get_inlining_signature_spec():
7574
dtype=tf.int64, shape=(), name='inlining_decision', minimum=0, maximum=1)
7675

7776
return time_step_spec, action_spec
78-
# LINT.ThenChange(.../rl/inlining/sparse_bucket_config.pbtxt)
7977

8078

8179
@gin.configurable

compiler_opt/rl/regalloc/config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ def get_num_registers():
2929
@gin.configurable()
3030
def get_regalloc_signature_spec():
3131
"""Returns (time_step_spec, action_spec) for LLVM register allocation."""
32-
# LINT.IfChange
3332
num_registers = get_num_registers()
3433

3534
observation_spec = dict(
@@ -66,7 +65,6 @@ def get_regalloc_signature_spec():
6665
maximum=num_registers - 1)
6766

6867
return time_step_spec, action_spec
69-
# LINT.ThenChange(.../rl/regalloc/sparse_bucket_config.pbtxt)
7068

7169

7270
@gin.configurable

docs/inlining-demo/demo.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,14 +254,14 @@ in the trace changes.
254254
```shell
255255
rm -rf $DEFAULT_VOCAB &&
256256
PYTHONPATH=$PYTHONPATH:. python3 \
257-
compiler_opt/tools/sparse_bucket_generator.py \
257+
compiler_opt/tools/generate_vocab.py \
258258
--gin_files=compiler_opt/rl/inlining/gin_configs/common.gin \
259259
--input=$DEFAULT_TRACE \
260260
--output_dir=$DEFAULT_VOCAB
261261
```
262262

263263
**Note**
264-
The `sparse_bucket_generator.py` tool optionally accepts two more additional
264+
The `generate_vocab.py` tool optionally accepts two more additional
265265
flags `--sampling_fraction` and `--parallelism`.
266266
`sampling_fraction` downsamples input features and `parallelism` controls the
267267
degree of parallelism.

docs/regalloc-demo/demo.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ model:
450450

451451
```bash
452452
rm -rf ./compiler_opt/rl/regalloc/vocab
453-
PYTHONPATH=$PYTHONPATH:. python3 compiler_opt/tools/sparse_bucket_generator.py \
453+
PYTHONPATH=$PYTHONPATH:. python3 compiler_opt/tools/generate_vocab.py \
454454
--input=$WORKING_DIR/default_trace \
455455
--output_dir=./compiler_opt/rl/regalloc/vocab \
456456
--gin_files=compiler_opt/rl/regalloc/gin_configs/common.gin

0 commit comments

Comments
 (0)