Skip to content

Commit 4bcd173

Browse files
authored
Log failed compilation attempts (#234)
Write a log message when compilation attempts fail or time out.
1 parent 6d16171 commit 4bcd173

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

compiler_opt/rl/compilation_runner.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import abc
1818
import dataclasses
1919
import os
20+
import shlex
2021
import signal
2122
import subprocess
2223
import tempfile
@@ -182,7 +183,7 @@ def start_cancellable_process(
182183
if _QUIET.value:
183184
command_env['TF_CPP_MIN_LOG_LEVEL'] = '1'
184185
else:
185-
logging.info(cmdline)
186+
logging.info(shlex.join(cmdline))
186187
with subprocess.Popen(
187188
cmdline,
188189
env=command_env,
@@ -193,15 +194,18 @@ def start_cancellable_process(
193194
try:
194195
retcode = p.wait(timeout=timeout)
195196
except subprocess.TimeoutExpired as e:
197+
logging.info('Command hit timeout: %s', shlex.join(cmdline))
196198
kill_process_ignore_exceptions(p)
197199
raise e
198200
finally:
199201
if cancellation_manager:
200202
cancellation_manager.unregister_process(p)
201203

202204
if retcode != 0:
203-
raise ProcessKilledError(
204-
) if retcode == -9 else subprocess.CalledProcessError(retcode, cmdline)
205+
if retcode == -9:
206+
raise ProcessKilledError()
207+
logging.info('Command returned code %d: %s', retcode, shlex.join(cmdline))
208+
raise subprocess.CalledProcessError(retcode, cmdline)
205209
else:
206210
if want_output:
207211
ret: bytes = p.stdout.read()

0 commit comments

Comments
 (0)