Skip to content

Commit 5eeb57e

Browse files
Update documentation to note the Chromium commit SHA to generate patches
Also fix a typo in the patch I just rebased.
1 parent 598c41f commit 5eeb57e

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

docs/regalloc-demo/demo.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ git apply $WORKING_DIR/ml-compiler-opt/experimental/chromium-thinlto-corpus-extr
8989
This will make a `clang_embed_bitcode` flag and a `lld_emit_index` flag
9090
available in the gn configuration.
9191

92+
**Note:** These patches may or may not work depending on code churn within the
93+
Chromium code base. They were generated with Chromium at commit
94+
`ee3114540941f915c673c85d1f21b9c16a42a287`. Doing a full fetch (i.e., omitting
95+
the `--no-history` flag) and then checking out that commit will give the best
96+
chance of success.
97+
9298
Now that this is all in place, you need to run the Chromium hooks in order to
9399
get the development environment ready for a full compilation:
94100

experimental/chromium-bitcode-embedding.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ index 1aad3d60b8404..c600c0edf481c 100644
88
clang_base_path = default_clang_base_path
99
+
1010
+ # Specifies whether or not bitcode should be embedded in all compiled targets
11-
+ clang_embit_bitcode = false
11+
+ clang_embed_bitcode = false
1212
}
1313
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
1414
index e89b62eb0aaf6..58bcaac2ffbf8 100644

0 commit comments

Comments
 (0)