Skip to content

Commit 7091b15

Browse files
Remove flag allow_override calls
These do not appear to do anything when using flagsaver for testing and are either commented out or years old. Remove them to reduce complexity slightly.
1 parent 37a6c90 commit 7091b15

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

compiler_opt/rl/imitation_learning/generate_bc_trajectories_test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
from compiler_opt.rl import env
3434
from compiler_opt.rl import env_test
3535

36-
# flags.FLAGS['gin_files'].allow_override = True
37-
# flags.FLAGS['gin_bindings'].allow_override = True
38-
3936
_eps = 1e-5
4037

4138

compiler_opt/tools/generate_default_trace_test.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import os
1717
from unittest import mock
1818

19-
from absl import flags
2019
from absl.testing import absltest
2120
from absl.testing import flagsaver
2221
import gin
@@ -29,10 +28,6 @@
2928

3029
from tf_agents.system import system_multiprocessing as multiprocessing
3130

32-
flags.FLAGS['num_workers'].allow_override = True
33-
flags.FLAGS['gin_files'].allow_override = True
34-
flags.FLAGS['gin_bindings'].allow_override = True
35-
3631

3732
@gin.configurable(module='runners')
3833
class MockCompilationRunner(compilation_runner.CompilationRunner):

compiler_opt/tools/generate_test_model_test.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,13 @@
1616
An integration test for model saving, to detect TFLite model conversion.
1717
"""
1818

19-
from absl import flags
2019
from absl.testing import absltest
2120
from absl.testing import flagsaver
2221
from absl.testing import parameterized
2322
import gin
2423

2524
from compiler_opt.tools import generate_test_model
2625

27-
flags.FLAGS['gin_files'].allow_override = True
28-
flags.FLAGS['gin_bindings'].allow_override = True
29-
3026

3127
def _get_test_settings():
3228
test_setting = []

0 commit comments

Comments
 (0)