[code quality] Tread warnings as errors; track allow-listed warnings.

Author: mtrofin

compiler_opt/rl/compilation_runner.py

@@ -80,7 +80,8 @@ def get_command_line_for_bundle(
     ir_file: str,
     thinlto: Optional[str] = None,
     additional_flags: Tuple[str, ...] = (),
-    delete_flags: Tuple[str, ...] = ()) -> List[str]:
+    delete_flags: Tuple[str, ...] = ()
+) -> List[str]:
   """Cleans up base command line.
 
   Remove certain unnecessary flags, and add the .bc file to compile and, if

compiler_opt/rl/data_collector.py

@@ -38,8 +38,7 @@
 def build_distribution_monitor(data: Sequence[float]) -> Dict[str, float]:
   if not data:
     return {}
-  quantiles = np.percentile(
-      data, REWARD_QUANTILE_MONITOR, interpolation='lower')
+  quantiles = np.percentile(data, REWARD_QUANTILE_MONITOR, method='lower')
   monitor_dict = {
       f'p_{x}': y for (x, y) in zip(REWARD_QUANTILE_MONITOR, quantiles)
   }

compiler_opt/rl/data_collector_test.py

@@ -28,7 +28,7 @@ class DataCollectorTest(absltest.TestCase):
   def test_build_distribution_monitor(self):
     data = [3, 2, 1]
     monitor_dict = data_collector.build_distribution_monitor(data)
-    self.assertDictContainsSubset({'mean': 2, 'p_0.1': 1}, monitor_dict)
+    self.assertEqual(monitor_dict, monitor_dict | {'mean': 2, 'p_0.1': 1})
 
   @mock.patch('time.time')
   def test_early_exit(self, mock_time):

compiler_opt/rl/local_data_collector_test.py

@@ -147,7 +147,7 @@ def _test_iterator_fn(data_list):
             'total_trajectory_length': 18,
         }
     }
-    self.assertDictContainsSubset(expected_monitor_dict_subset, monitor_dict)
+    self.assertEqual(monitor_dict, monitor_dict | expected_monitor_dict_subset)
 
     data_iterator, monitor_dict = collector.collect_data(policy_path='policy')
     data = list(data_iterator)
@@ -158,7 +158,7 @@ def _test_iterator_fn(data_list):
             'total_trajectory_length': 18,
         }
     }
-    self.assertDictContainsSubset(expected_monitor_dict_subset, monitor_dict)
+    self.assertEqual(monitor_dict, monitor_dict | expected_monitor_dict_subset)
 
     collector.close_pool()
 

pytest.ini

@@ -0,0 +1,16 @@
+# DO always create a tracking issue when allow-listing warnings
+# DO NOT disable warnings-as-error: warnings of today are tomorrow's evolvability blocker.
+[pytest]
+filterwarnings =
+	# Tread warnings as errors
+	error
+
+	# ...except this allow list:
+	# Issue #35
+	ignore:the imp module is deprecated:DeprecationWarning
+
+	# Issue #36
+	ignore:`np.bool` is a deprecated alias:DeprecationWarning
+
+	# Issue #37
+	ignore:Encoding a StructuredValue with type tf_agents.policies.greedy_policy.DeterministicWithLogProb_ACTTypeSpec:UserWarning