Skip to content

Commit aeb1eb2

Browse files
Remove dangling TENSORFLOW_C_LIB_PATH references in benchmarking code
This patch removes a couple dangling TENSORFLOW_C_LIB_PATH references that I failed to catch in #150. Fixes #250, as I thought I hadn't updated anything yet, but I was just seeing some dangling references.
1 parent 248b2ee commit aeb1eb2

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

compiler_opt/benchmark/benchmarking_utils.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,10 @@ def build_llvm(model_path: str, use_existing_build: bool, llvm_build_path: str,
3737
use_existing_build: Whether or not to do an incremental build
3838
llvm_build_path: The path to where the LLVM build will go
3939
llvm_source_path: The path to the root of the llvm-project repository
40-
tensorflow_c_lib_path: The path to the tensorflow c lib path
4140
42-
Note: llvm_source_path and tensorflow_c_lib_path aren't necessary if you have
43-
set use_existing_build to true, you just need to make sure that the existing
44-
build is already set up to enable the necessary MLGO flags.
41+
Note: llvm_source_path is not necessary if you have set use_existing_build to
42+
true, you just need to make sure that the existing build is already set up to
43+
enable the necessary MLGO flags.
4544
"""
4645
if not use_existing_build and os.path.exists(llvm_build_path):
4746
shutil.rmtree(llvm_build_path)

docs/benchmarking.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ PYTHONPATH=$PYTHONPATH:. python3 ./compiler_opt/benchmark/benchmark_llvm_test_su
5353
--output_path=./results.json \
5454
--perf_counter=INSTRUCTIONS \
5555
--perf_counter=MEM_UOPS_RETIRED:ALL_LOADS \
56-
--perf_counter=MEM_UOPS_RETIRED:ALL_STORES \
57-
--tensorflow_c_lib_path=~/tensorflow
56+
--perf_counter=MEM_UOPS_RETIRED:ALL_STORES
5857
```
5958

6059
This will output a bunch of test information to `./results.json` that can then
@@ -90,8 +89,6 @@ If it is set to "" or "autogenerate", it will use the autogenerated model.
9089
performance counters in the libpfm format. There can only be up to three
9190
performance counters specified due to underlying limitations in Google
9291
benchmark.
93-
* `tensorflow_c_lib_path` - The path to the tensorflow c library if you aren't
94-
doing an incremental LLVM build.
9592
* `tests_to_run` - This specifies the LLVM microbenchmarks to run relative to
9693
the microbenchmarks library in the LLVM test suite build directory. The default
9794
values for this flag should be pretty safe and produce good results.
@@ -122,8 +119,7 @@ PYTHONPATH=$PYTHONPATH:. python3 ./compiler_opt/benchmark/benchmark_chromium.py
122119
--num_threads=32 \
123120
--output_file=./output-chromium-testing.json \
124121
--perf_counters=mem_uops_retired.all_loads \
125-
--perf_counters=mem_uops_retired.all_stores \
126-
--tensorflow_c_lib_path=~/tensorflow
122+
--perf_counters=mem_uops_retired.all_stores
127123
```
128124

129125
Several of the flags here are extremely similar to/the same as the flags

0 commit comments

Comments
 (0)