Skip to content

Commit e73ee90

Browse files
authored
Enable --overriding-parameter-count-checks for ptype and fix related failures (#216)
1 parent 0f24e63 commit e73ee90

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
task: [Typecheck, Lint, Yapf, Test]
3939
include:
4040
- task: Typecheck
41-
cmd: pytype -j auto .
41+
cmd: pytype -j auto --overriding-parameter-count-checks .
4242
- task: Lint
4343
cmd: pylint --rcfile .pylintrc --recursive yes .
4444
- task: Yapf

compiler_opt/rl/local_data_collector_test.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,11 @@ def mock_collect_data(loaded_module_spec: corpus.LoadedModuleSpec, policy,
8989
class Sleeper(compilation_runner.CompilationRunner):
9090
"""Test CompilationRunner that just sleeps."""
9191

92-
def collect_data(self, loaded_module_spec, policy, reward_stat, model_id):
92+
def collect_data(self,
93+
loaded_module_spec,
94+
policy=None,
95+
reward_stat=None,
96+
model_id=None):
9397
_ = loaded_module_spec, policy, reward_stat
9498
compilation_runner.start_cancellable_process(['sleep', '3600s'], 3600,
9599
self._cancellation_manager)

compiler_opt/tools/generate_default_trace_test.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@
3636
class MockCompilationRunner(compilation_runner.CompilationRunner):
3737
"""A compilation runner just for test."""
3838

39-
def collect_data(self, loaded_module_spec, policy, reward_stat, model_id):
39+
def collect_data(self,
40+
loaded_module_spec,
41+
policy=None,
42+
reward_stat=None,
43+
model_id=None):
4044
sequence_example_text = """
4145
feature_lists {
4246
feature_list {

0 commit comments

Comments
 (0)