`DateTimeFormatsTest` fails when built in GB

[facboy]

not sure where else it fails, but a number of the tests fail when built in GB.

[INFO] Running com.google.mu.time.DateTimeFormatsTest
[ERROR] Tests run: 306, Failures: 6, Errors: 8, Skipped: 1, Time elapsed: 0.384 s <<< FAILURE! - in com.google.mu.time.DateTimeFormatsTest
[ERROR] singleDigitHourMinuteWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.002 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '1:10AM' could not be parsed at index 4
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.singleDigitHourMinuteWithAmPm(DateTimeFormatsTest.java:84)
[ERROR] withZoneIdExamplesFromDifferentFormatters[5.yyyy/MM/dd HH:mm:ssa VV,1.2020-01-01T00:00:01-07:00[America/New_York]](com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0 s  <<< ERROR!
java.time.DateTimeException: unsupported date time example: 2020/01/01 02:00:01am America/New_York
        at com.google.mu.time.DateTimeFormatsTest.withZoneIdExamplesFromDifferentFormatters(DateTimeFormatsTest.java:586)
[ERROR] withZoneIdExamplesFromDifferentFormatters[5.yyyy/MM/dd HH:mm:ssa VV,2.1979-01-01T00:00:00+01:00[Europe/Paris]](com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0 s  <<< ERROR!
java.time.DateTimeException: unsupported date time example: 1979/01/01 00:00:00am Europe/Paris
        at com.google.mu.time.DateTimeFormatsTest.withZoneIdExamplesFromDifferentFormatters(DateTimeFormatsTest.java:586)
[ERROR] twoDigitHourWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.001 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '09AM' could not be parsed at index 2
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.twoDigitHourWithAmPm(DateTimeFormatsTest.java:102)
[ERROR] formatOf_12HourFormat(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.012 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: format(...)
expected: 20 10 2023 AD 01:02 AM -07:00
but was : 20 10 2023 AD 01:02 am -07:00
        at com.google.mu.time.DateTimeFormatsTest.formatOf_12HourFormat(DateTimeFormatsTest.java:435)
[ERROR] twoDigitHourMinuteSecondWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.001 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '09:00:30AM' could not be parsed at index 8
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.twoDigitHourMinuteSecondWithAmPm(DateTimeFormatsTest.java:120)
[ERROR] timeZoneMixedIn_twoLetterZoneNameAbbreviation(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.01 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: parse(...)
expected: 2023-01-10T10:20:30-08:00[America/Los_Angeles]
but was : 2023-01-10T10:20:30-08:00[America/Tijuana]
        at com.google.mu.time.DateTimeFormatsTest.timeZoneMixedIn_twoLetterZoneNameAbbreviation(DateTimeFormatsTest.java:998)
[ERROR] zoneIdRetainedExamples[9.yyyy-MM-dd HH:mm:ss.SSSSSS z,1.2020-01-01T00:00:01-07:00[America/New_York]](com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.003 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: parse(...)
expected: 2020-01-01T02:00:01-05:00[America/New_York]
but was : 2020-01-01T02:00:01-05:00
        at com.google.mu.time.DateTimeFormatsTest.zoneIdRetainedExamples(DateTimeFormatsTest.java:616)
[ERROR] zoneIdRetainedExamples[10.yyyy-MM-dd HH:mm:ss.SSSSSS zz,1.2020-01-01T00:00:01-07:00[America/New_York]](com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.002 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: parse(...)
expected: 2020-01-01T02:00:01-05:00[America/New_York]
but was : 2020-01-01T02:00:01-05:00
        at com.google.mu.time.DateTimeFormatsTest.zoneIdRetainedExamples(DateTimeFormatsTest.java:616)
[ERROR] zoneIdRetainedExamples[11.yyyy-MM-dd HH:mm:ss.SSSSSS zzz,1.2020-01-01T00:00:01-07:00[America/New_York]](com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: parse(...)
expected: 2020-01-01T02:00:01-05:00[America/New_York]
but was : 2020-01-01T02:00:01-05:00
        at com.google.mu.time.DateTimeFormatsTest.zoneIdRetainedExamples(DateTimeFormatsTest.java:616)
[ERROR] twoDigitHourMinuteWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.001 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '09:00AM' could not be parsed at index 5
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.twoDigitHourMinuteWithAmPm(DateTimeFormatsTest.java:114)
[ERROR] timeZoneMixedIn_abbreviatedZoneName(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0.002 s  <<< FAILURE!
com.google.common.truth.ComparisonFailureWithFacts:
value of: parse(...)
expected: 2023-01-10T10:20:30-08:00[America/Los_Angeles]
but was : 2023-01-10T10:20:30-08:00[America/Tijuana]
        at com.google.mu.time.DateTimeFormatsTest.timeZoneMixedIn_abbreviatedZoneName(DateTimeFormatsTest.java:1017)
[ERROR] singleDigitHourMinuteSecondWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '1:10:30AM' could not be parsed at index 7
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.singleDigitHourMinuteSecondWithAmPm(DateTimeFormatsTest.java:96)
[ERROR] singleDigitHourWithAmPm(com.google.mu.time.DateTimeFormatsTest)  Time elapsed: 0 s  <<< ERROR!
java.time.format.DateTimeParseException: Text '1AM' could not be parsed at index 1
        at com.google.mu.time.DateTimeFormatsTest.assertLocalTime(DateTimeFormatsTest.java:1356)
        at com.google.mu.time.DateTimeFormatsTest.singleDigitHourWithAmPm(DateTimeFormatsTest.java:72)

[fluentfuture]

Sorry, what is "GB"?

[facboy]

GB locale, i.e. UK.

[fluentfuture]

Will give it a try later. Just to confirm: you were using a computer with the default locale or region set to UK, and used mvn test without any flags, yes?

[facboy]

yes. mvn install actually.

[fluentfuture]

The tests fail because the inference of PM (to a) and PST (to zzz) are locale specific. And some of the test logic expect US locale too.

I've fixed the tests by isolating out the locale specific test cases. And also added inference for am, pm, a.m. and p.m. for some of these European locales.

Please give it a try.

[facboy]

still 2 errors, 2 failures:

[ERROR] Failures:
[ERROR]   DateTimeFormatsTest.formatOf_fullWeekdayAndMonthNamePlaceholder:453->assertEquivalent:1424 value of: format(...)
expected: Friday, October 20 2023 01:02:03 -07:00 America/Los_Angeles
but was : Fri, Oct 20 2023 01:02:03 -07:00 America/Los_Angeles
[ERROR]   DateTimeFormatsTest.formatOf_zoneOffsetNotRetranslated:478->assertEquivalent:1424 value of: format(...)
expected: Fri, Oct 20 2023 01:02:03 Pacific Daylight Time
but was : Fri, Oct 20 2023 01:02:03 Los Angeles (+1)
[ERROR] Errors:
[ERROR]   DateTimeFormatsTest.withZoneIdExamplesFromDifferentFormatters:613 » DateTimeParse
[ERROR]   DateTimeFormatsTest.withZoneIdExamplesFromDifferentFormatters:613 » DateTimeParse
[INFO]
[ERROR] Tests run: 38128, Failures: 2, Errors: 2, Skipped: 170

[fluentfuture]

Thanks!

I think I might have fixed the formatOf_zoneOffsetNotRetranslated(), though I was not able to reproduce the error locally (running defaults read -g AppleLocale on a Mac gave me en_GB but the tests all pass).

I have not figured out why in formatOf_fullWeekdayAndMonthNamePlaceholder() the inferred format would use DayOfWeek.SHORT instead of DayOfWeek for Tuesday, or if that was the issue at all, because I failed to repro.

I've changed the assertEquivalent() helper to also print the DateTimeFormatter that was inferred, so hopefully it can show some more context.

If you can show me the error message that may shed some light.

Sadly we have to suffer the painful cloud debugging. :-)