Skip to content

Commit 7bbb2a1

Browse files
committed
Fix OOM in UploadBsaUnavailableDomains action
The action was using string concatenation to generate the upload content. This causes an OOM when string length exceeds 25MB on our current VM. This PR witches to streaming upload. Also added an HTTP upload test.
1 parent 69e1345 commit 7bbb2a1

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

core/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ def fragileTestPatterns = [
5858
// Changes cache timeouts and for some reason appears to have contention
5959
// with other tests.
6060
"google/registry/whois/WhoisCommandFactoryTest.*",
61+
// Breaks random other tests when running with standardTests.
62+
"google/registry/bsa/UploadBsaUnavailableDomainsActionTest.*",
6163
// Currently changes a global configuration parameter that for some reason
6264
// results in timestamp inversions for other tests. TODO(mmuller): fix.
6365
"google/registry/flows/host/HostInfoFlowTest.*",

core/src/test/java/google/registry/bsa/UploadBsaUnavailableDomainsActionTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
import org.joda.time.DateTime;
6969
import org.junit.jupiter.api.BeforeEach;
7070
import org.junit.jupiter.api.Test;
71-
import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable;
7271
import org.junit.jupiter.api.extension.ExtendWith;
7372
import org.junit.jupiter.api.extension.RegisterExtension;
7473
import org.mockito.Mock;
@@ -138,8 +137,6 @@ void calculatesEntriesCorrectly() throws Exception {
138137
.sendNotification("BSA daily upload completed with errors", "Please see logs for details.");
139138
}
140139

141-
// TODO(weiminyu): Breaks other tests on Kokoro. Investigate.
142-
@DisabledIfEnvironmentVariable(named = "KOKORO_JOB_NAME", matches = ".*")
143140
@Test
144141
void uploadToBsaTest() throws Exception {
145142
TestLogHandler logHandler = new TestLogHandler();

0 commit comments

Comments
 (0)