Skip to content

Commit d4a70c2

Browse files
authored
Upload compatibility test jars to release folder (#2873)
We need to stop using maven repo on GCS to store artifacts for the schema compatibility tests. After public access is removed from GCS buckets, Kokoro won't be able to access it: normal access will be denied, and the repo is too large to map (copy) to Kokoro VM as a resource. This PR uploads the relevant jars to each release's folder. See go/dr-gcs-public-access-prevention for details.
1 parent 7b8d079 commit d4a70c2

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

release/cloudbuild-nomulus.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,11 @@ steps:
177177
-PpluginsUrl=gcs://domain-registry-maven-repository/plugins \
178178
-Ppublish_repo=gcs://${PROJECT_ID}-deployed-tags/maven \
179179
-Pnomulus_version=${TAG_NAME}
180-
# Upload schema jar for use by schema deployment.
181-
# TODO(weiminyu): consider using the jar in maven repo during deployment and
182-
# stop the upload here.
180+
# Upload jars for use by schema deployment and schema compatibility test.
181+
# The jars published to GCS will be unaccessible to Kokoro once public access is removed.
183182
cp db/build/libs/schema.jar output/
183+
cp core/build/libs/nomulus-public.jar output/
184+
cp core/build/libs/nomulus-tests-alldeps.jar output/
184185
# The tarballs and jars to upload to GCS.
185186
artifacts:
186187
objects:
@@ -189,6 +190,8 @@ artifacts:
189190
- 'output/*.tar'
190191
- 'output/tag_name'
191192
- 'output/nomulus.jar'
193+
- 'output/nomulus-public.jar'
194+
- 'output/nomulus-tests-alldeps.jar'
192195
- 'output/schema.jar'
193196
- 'core/src/main/java/google/registry/config/files/nomulus-config-*.yaml'
194197
- 'core/src/main/java/google/registry/config/files/cloud-tasks-queue.xml'

0 commit comments

Comments
 (0)