Show failed measurement-less phases as failed (#1020)

By adding `skip`, `error` states and using PhaseRecord.outcome instead of checking measurement.status.

Co-authored-by: cpaulin <[email protected]>

Author: lalten

openhtf/output/web_gui/src/app/shared/models/phase.model.ts

@@ -14,6 +14,8 @@ export enum PhaseStatus {
   running,
   pass,
   fail,
+  skip,
+  error,
 }
 
 export class Phase {

openhtf/output/web_gui/src/app/shared/models/station.model.ts

@@ -3,7 +3,7 @@
  */
 
 export enum StationStatus {
-  online = 7,
+  online = 9,
   unreachable,
 }
 

openhtf/output/web_gui/src/app/shared/models/test-state.model.ts

@@ -10,7 +10,7 @@ import { Station } from './station.model';
 // Enum values must not overlap between any of the status enums.
 // See status-pipes.ts.
 export enum TestStatus {
-  waiting = 9,  // Corresponds to WAITING_FOR_TEST_START.
+  waiting = 11,  // Corresponds to WAITING_FOR_TEST_START.
   running,
   pass,
   fail,

openhtf/output/web_gui/src/app/shared/status-pipes.ts

@@ -43,6 +43,8 @@ const statusToCategory = {
   [PhaseStatus.running]: StatusCategory.running,
   [PhaseStatus.pass]: StatusCategory.pass,
   [PhaseStatus.fail]: StatusCategory.fail,
+  [PhaseStatus.skip]: StatusCategory.unreachable,
+  [PhaseStatus.error]: StatusCategory.warning,
   [StationStatus.online]: StatusCategory.online,
   [StationStatus.unreachable]: StatusCategory.unreachable,
   [TestStatus.waiting]: StatusCategory.pending,
@@ -63,6 +65,8 @@ const statusToText = {
   [PhaseStatus.running]: 'Running',
   [PhaseStatus.pass]: 'Pass',
   [PhaseStatus.fail]: 'Fail',
+  [PhaseStatus.skip]: 'Skip',
+  [PhaseStatus.error]: 'Error',
   [StationStatus.online]: 'Online',
   [StationStatus.unreachable]: 'Unreachable',
   [TestStatus.waiting]: 'Waiting',

openhtf/output/web_gui/src/app/stations/station/station-data.ts

@@ -33,6 +33,13 @@ const measurementStatusMap = {
   'PARTIALLY_SET': MeasurementStatus.unset,
 };
 
+const phaseRecordOutcomeMap = {
+  'PASS': PhaseStatus.pass,
+  'FAIL': PhaseStatus.fail,
+  'SKIP': PhaseStatus.skip,
+  'ERROR': PhaseStatus.error,
+};
+
 export interface RawTestState {
   plugs: RawPlugsInfo;
   running_phase_state: RawPhase|null;
@@ -78,6 +85,7 @@ export interface RawPhase {
   name: string;
   result?: {};  // Not present on running phase state.
   start_time_millis: number;
+  outcome: string;
 }
 
 export interface RawAttachment {
@@ -201,13 +209,7 @@ function makePhase(phase: RawPhase, running: boolean) {
   if (running) {
     status = PhaseStatus.running;
   } else {
-    status = PhaseStatus.pass;
-    for (const measurement of measurements) {
-      if (measurement.status !== MeasurementStatus.pass) {
-        status = PhaseStatus.fail;
-        break;
-      }
-    }
+    status = phaseRecordOutcomeMap[phase.outcome];
   }
   return new Phase({
     attachments,