Handle skipped phases in ConsoleSummary (#990)

Fixes #982

Author: lalten

openhtf/output/callbacks/console_summary.py

@@ -67,7 +67,8 @@ def __call__(self, record):
         if not phase_result:  # Timeout.
           output_lines.append('timeout phase: %s [ran for %.2f sec]' %
                               (phase.name, phase_time_sec))
-        elif 'CONTINUE' not in str(phase_result):  # Exception.
+        elif 'CONTINUE' not in str(phase_result) and record.outcome_details:
+          # Exception.
           output_lines.append('%sexception type: %s' %
                               (self.indent, record.outcome_details[0].code))
 

test/output/callbacks/callbacks_test.py

@@ -25,6 +25,7 @@
 import openhtf as htf
 from openhtf import util
 from examples import all_the_things
+from openhtf.core import phase_branches, phase_descriptor, phase_collections, phase_group
 from openhtf.output.callbacks import console_summary
 from openhtf.output.callbacks import json_factory
 from openhtf.output.proto import mfg_event_converter
@@ -176,3 +177,25 @@ def test_outcome_colors(self):
     instance = console_summary.ConsoleSummary()
     for outcome in htf.test_record.Outcome:
       self.assertIn(outcome, instance.color_table)
+
+  def test_empty_outcome(self):
+    """Console Summary must not crash if phases have been skipped."""
+    checkpoint = phase_branches.PhaseFailureCheckpoint.all_previous(
+      "cp", action=phase_descriptor.PhaseResult.FAIL_SUBTEST)
+    phasegroup = phase_group.PhaseGroup(
+      lambda: htf.PhaseResult.FAIL_AND_CONTINUE,
+      lambda: htf.PhaseResult.SKIP,
+      checkpoint,
+    )
+    subtest = phase_collections.Subtest("st", phasegroup)
+    test = htf.Test(subtest)
+
+    result_store = util.NonLocalResult()
+    def _save_result(test_record):
+      result_store.result = test_record
+    test.add_output_callbacks(
+        console_summary.ConsoleSummary(), _save_result)
+
+    test.execute()
+    assert not any("Traceback" in record.message
+                   for record in result_store.result.log_records)