Skip to content

Commit 36cd876

Browse files
OSS-Fuzz Teamcopybara-github
authored andcommitted
clang_wrapper: Remove hardcoded -fsanitize-coverage= in clang wrapper.
PiperOrigin-RevId: 820402972
1 parent 3174fff commit 36cd876

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

infra/base-images/base-builder/indexer/clang_wrapper.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ def check_fuzzing_engine_and_fix_argv(argv: MutableSequence[str]) -> bool:
342342
elif "fuzzer-no-link" in sanitize_vals:
343343
sanitize_vals.remove("fuzzer-no-link")
344344
arg = "-fsanitize=" + ",".join(sanitize_vals)
345-
346345
argv[idx] = arg
347346

348347
if fuzzing_engine_in_argv:
@@ -478,8 +477,11 @@ def fix_coverage_flags(
478477
# Some projects use -fsanitize-coverage-allowlist/ignorelist to optimize
479478
# fuzzing feedback. For the indexer case, we would prefer to have all code
480479
# instrumented, so we remove these flags.
480+
# Some projects hardcode -fsanitize-coverage= options that cause conflicts
481+
# with our indexer / tracer options.
481482
if (arg.startswith("-fsanitize-coverage-allowlist=") or
482-
arg.startswith("-fsanitize-coverage-ignorelist=")):
483+
arg.startswith("-fsanitize-coverage-ignorelist=") or
484+
arg.startswith("-fsanitize-coverage=")):
483485
continue
484486

485487
args.append(arg)

infra/base-images/base-builder/indexer/clang_wrapper_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def test_remove_invalid_coverage_flags(self):
4545
"-foo",
4646
"-fsanitize-coverage-allowlist=allowlist",
4747
"-fsanitize-coverage-ignorelist=ignorelist",
48+
"-fsanitize-coverage=edge",
4849
"-c",
4950
"test.c",
5051
]

0 commit comments

Comments
 (0)