Skip to content

Commit e7daf97

Browse files
authored
Update build.sh to reflect upstream changes in dependencies (#14180)
We changed how the dependencies are set up in our repo. We need to update this build process to reflect those and ensure linking doesn't fail. Thanks!
1 parent bfaadb3 commit e7daf97

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

projects/hpn-ssh/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
################################################################################
1616

1717
FROM gcr.io/oss-fuzz-base/base-builder
18-
RUN apt-get update && apt-get install -y make autoconf automake libtool
19-
RUN apt-get install -y libz-dev libssl1.1 libssl-dev libedit-dev zip libpkcs11
18+
RUN apt-get update && apt-get install -y make autoconf automake libtool
19+
RUN apt-get update && apt-get install -y libz-dev libssl1.1 libssl-dev libedit-dev zip
2020
RUN git clone https://github.com/rapier1/hpn-ssh
2121
RUN git clone --depth 1 https://github.com/djmdjm/openssh-fuzz-cases
2222
WORKDIR hpn-ssh

projects/hpn-ssh/build.sh

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
#
1616
################################################################################
1717

18-
#git pull --all
19-
#git checkout oss_fuzz_tests
18+
git pull --all
19+
git checkout dev_minor
2020

2121
# Enable null cipher
2222
sed -i 's/#define CFLAG_INTERNAL.*/#define CFLAG_INTERNAL 0/' cipher.c
@@ -41,11 +41,12 @@ fi
4141
make -j$(nproc) all
4242

4343
# Build fuzzers
44-
EXTRA_CFLAGS="-DCIPHER_NONE_AVAIL=1"
44+
EXTRA_CFLAGS="-DCIPHER_NONE_AVAIL=1 -D_GNU_SOURCE -Iopenbsd-compat/include"
4545
STATIC_CRYPTO="-Wl,-Bstatic -lcrypto -Wl,-Bdynamic"
4646

4747
SK_NULL=ssh-sk-null.o
4848
SK_DUMMY=sk-dummy.o
49+
COMMON_DEPS="ssh-pkcs11-client.o -lssh -lopenbsd-compat"
4950

5051
$CC $CFLAGS $EXTRA_CFLAGS -I. -g -c \
5152
regress/misc/fuzz-harness/ssh-sk-null.cc -o ssh-sk-null.o
@@ -54,36 +55,36 @@ $CC $CFLAGS $EXTRA_CFLAGS -I. -g -c \
5455

5556
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
5657
regress/misc/fuzz-harness/pubkey_fuzz.cc -o $OUT/pubkey_fuzz \
57-
-lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
58+
$COMMON_DEPS $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
5859
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
5960
regress/misc/fuzz-harness/privkey_fuzz.cc -o $OUT/privkey_fuzz \
60-
-lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
61+
$COMMON_DEPS $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
6162
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
6263
regress/misc/fuzz-harness/sig_fuzz.cc -o $OUT/sig_fuzz \
63-
-lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
64+
$COMMON_DEPS $SK_NULL $STATIC_CRYPTO $LIB_FUZZING_ENGINE
6465
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
6566
regress/misc/fuzz-harness/authopt_fuzz.cc -o $OUT/authopt_fuzz \
66-
auth-options.o -lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO \
67+
auth-options.o $COMMON_DEPS $SK_NULL $STATIC_CRYPTO \
6768
$LIB_FUZZING_ENGINE
6869
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
6970
regress/misc/fuzz-harness/sshsig_fuzz.cc -o $OUT/sshsig_fuzz \
70-
sshsig.o -lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO \
71+
sshsig.o $COMMON_DEPS $SK_NULL $STATIC_CRYPTO \
7172
$LIB_FUZZING_ENGINE
7273
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
7374
regress/misc/fuzz-harness/sshsigopt_fuzz.cc -o $OUT/sshsigopt_fuzz \
74-
sshsig.o -lssh -lopenbsd-compat $SK_NULL $STATIC_CRYPTO \
75+
sshsig.o $COMMON_DEPS $SK_NULL $STATIC_CRYPTO \
7576
$LIB_FUZZING_ENGINE
7677
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
7778
regress/misc/fuzz-harness/kex_fuzz.cc -o $OUT/kex_fuzz \
78-
-lssh -lopenbsd-compat -lz $SK_NULL $STATIC_CRYPTO \
79+
$COMMON_DEPS -lz $SK_NULL $STATIC_CRYPTO \
7980
$LIB_FUZZING_ENGINE
8081

8182
$CC $CFLAGS $EXTRA_CFLAGS -I. -g -c \
8283
regress/misc/fuzz-harness/agent_fuzz_helper.c -o agent_fuzz_helper.o
8384
$CC $CFLAGS $EXTRA_CFLAGS -I. -g -c -DENABLE_SK_INTERNAL=1 ssh-sk.c -o ssh-sk.o
8485
$CXX $CXXFLAGS -std=c++11 $EXTRA_CFLAGS -I. -L. -Lopenbsd-compat -g \
8586
regress/misc/fuzz-harness/agent_fuzz.cc -o $OUT/agent_fuzz \
86-
$SK_DUMMY agent_fuzz_helper.o ssh-sk.o -lssh -lopenbsd-compat -lz \
87+
$SK_DUMMY agent_fuzz_helper.o ssh-sk.o $COMMON_DEPS -lz \
8788
$STATIC_CRYPTO $LIB_FUZZING_ENGINE
8889

8990
# Prepare seed corpora

0 commit comments

Comments
 (0)