Skip to content

Commit 43c5e13

Browse files
authored
fix: update go pubsub library to v2 (#4056)
Re: #4018 (comment)
1 parent 0b96d3a commit 43c5e13

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

go/cmd/recordchecker/recordchecker.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
"time"
1313

1414
"cloud.google.com/go/datastore"
15-
"cloud.google.com/go/pubsub"
15+
"cloud.google.com/go/pubsub/v2"
1616
"cloud.google.com/go/storage"
1717
"github.com/google/osv.dev/go/logger"
1818
"github.com/google/osv.dev/go/models"
@@ -118,7 +118,7 @@ func run(ctx context.Context, env *appEnv) error {
118118
go func() {
119119
defer resultsWg.Done()
120120
for result := range resultsChan {
121-
if handleResult(ctx, env.topic, result) {
121+
if handleResult(ctx, env.publisher, result) {
122122
newInvalids = append(newInvalids, result.id)
123123
}
124124
}
@@ -182,7 +182,7 @@ func run(ctx context.Context, env *appEnv) error {
182182
// handleResult handles logging and sending pub/sub message to the recoverer.
183183
// Returns true if a pub/sub message was sent to the recoverer,
184184
// to indicate that we need to verify that the recoverer fixes the problem on the next run.
185-
func handleResult(ctx context.Context, topic *pubsub.Topic, result checkRecordResult) bool {
185+
func handleResult(ctx context.Context, publisher *pubsub.Publisher, result checkRecordResult) bool {
186186
if result.err != nil {
187187
logger.Error("failed to process record", slog.String("id", result.id), slog.Any("err", result.err))
188188
}
@@ -191,7 +191,7 @@ func handleResult(ctx context.Context, topic *pubsub.Topic, result checkRecordRe
191191
Attributes: map[string]string{"type": "gcs_missing", "id": result.id},
192192
}
193193
logger.Info("publishing gcs_missing message", slog.String("id", result.id))
194-
_, err := topic.Publish(ctx, &msg).Get(ctx)
194+
_, err := publisher.Publish(ctx, &msg).Get(ctx)
195195
if err != nil {
196196
logger.Error("failed publishing message", slog.String("id", result.id), slog.Any("err", err))
197197
}
@@ -204,7 +204,7 @@ func handleResult(ctx context.Context, topic *pubsub.Topic, result checkRecordRe
204204
type appEnv struct {
205205
bucket *storage.BucketHandle
206206
ds *datastore.Client
207-
topic *pubsub.Topic
207+
publisher *pubsub.Publisher
208208
numWorkers int
209209
}
210210

@@ -239,7 +239,7 @@ func setup(ctx context.Context) (*appEnv, error) {
239239
err = fmt.Errorf("failed to create pubsub client: %w", err)
240240
return nil, err
241241
}
242-
topic := pubsubClient.Topic(pubsubTopic)
242+
publisher := pubsubClient.Publisher(pubsubTopic)
243243

244244
numWorkers := defaultNumWorkers
245245
if numWorkersStr, ok := os.LookupEnv("NUM_WORKERS"); ok {
@@ -253,7 +253,7 @@ func setup(ctx context.Context) (*appEnv, error) {
253253
return &appEnv{
254254
bucket: bucket,
255255
ds: dsClient,
256-
topic: topic,
256+
publisher: publisher,
257257
numWorkers: numWorkers,
258258
}, nil
259259
}

go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.24.6
44

55
require (
66
cloud.google.com/go/datastore v1.20.0
7-
cloud.google.com/go/pubsub v1.49.0
7+
cloud.google.com/go/pubsub/v2 v2.1.0
88
cloud.google.com/go/storage v1.57.0
99
github.com/charmbracelet/lipgloss v1.1.0
1010
google.golang.org/api v0.249.0

go/go.sum

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,14 @@ cloud.google.com/go/datastore v1.20.0 h1:NNpXoyEqIJmZFc0ACcwBEaXnmscUpcG4NkKnbCe
1313
cloud.google.com/go/datastore v1.20.0/go.mod h1:uFo3e+aEpRfHgtp5pp0+6M0o147KoPaYNaPAKpfh8Ew=
1414
cloud.google.com/go/iam v1.5.2 h1:qgFRAGEmd8z6dJ/qyEchAuL9jpswyODjA2lS+w234g8=
1515
cloud.google.com/go/iam v1.5.2/go.mod h1:SE1vg0N81zQqLzQEwxL2WI6yhetBdbNQuTvIKCSkUHE=
16-
cloud.google.com/go/kms v1.22.0 h1:dBRIj7+GDeeEvatJeTB19oYZNV0aj6wEqSIT/7gLqtk=
17-
cloud.google.com/go/kms v1.22.0/go.mod h1:U7mf8Sva5jpOb4bxYZdtw/9zsbIjrklYwPcvMk34AL8=
1816
cloud.google.com/go/logging v1.13.0 h1:7j0HgAp0B94o1YRDqiqm26w4q1rDMH7XNRU34lJXHYc=
1917
cloud.google.com/go/logging v1.13.0/go.mod h1:36CoKh6KA/M0PbhPKMq6/qety2DCAErbhXT62TuXALA=
2018
cloud.google.com/go/longrunning v0.6.7 h1:IGtfDWHhQCgCjwQjV9iiLnUta9LBCo8R9QmAFsS/PrE=
2119
cloud.google.com/go/longrunning v0.6.7/go.mod h1:EAFV3IZAKmM56TyiE6VAP3VoTzhZzySwI/YI1s/nRsY=
2220
cloud.google.com/go/monitoring v1.24.2 h1:5OTsoJ1dXYIiMiuL+sYscLc9BumrL3CarVLL7dd7lHM=
2321
cloud.google.com/go/monitoring v1.24.2/go.mod h1:x7yzPWcgDRnPEv3sI+jJGBkwl5qINf+6qY4eq0I9B4U=
24-
cloud.google.com/go/pubsub v1.49.0 h1:5054IkbslnrMCgA2MAEPcsN3Ky+AyMpEZcii/DoySPo=
25-
cloud.google.com/go/pubsub v1.49.0/go.mod h1:K1FswTWP+C1tI/nfi3HQecoVeFvL4HUOB1tdaNXKhUY=
22+
cloud.google.com/go/pubsub/v2 v2.1.0 h1:FLUDATKgCg1iUC+c9+m4JlsUxajEtc7L1Ynu3acrzww=
23+
cloud.google.com/go/pubsub/v2 v2.1.0/go.mod h1:O5f0KHG9zDheZAd3z5rlCRhxt2JQtB+t/IYLKK3Bpvw=
2624
cloud.google.com/go/storage v1.57.0 h1:4g7NB7Ta7KetVbOMpCqy89C+Vg5VE8scqlSHUPm7Rds=
2725
cloud.google.com/go/storage v1.57.0/go.mod h1:329cwlpzALLgJuu8beyJ/uvQznDHpa2U5lGjWednkzg=
2826
cloud.google.com/go/trace v1.11.6 h1:2O2zjPzqPYAHrn3OKl029qlqG6W8ZdYaOWRyr8NgMT4=
@@ -146,8 +144,8 @@ github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e h1:JVG44RsyaB9T2KIHavM
146144
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e/go.mod h1:RbqR21r5mrJuqunuUZ/Dhy/avygyECGrLceyNeo4LiM=
147145
github.com/zeebo/errs v1.4.0 h1:XNdoD/RRMKP7HD0UhJnIzUy74ISdGGxURlYG8HSWSfM=
148146
github.com/zeebo/errs v1.4.0/go.mod h1:sgbWHsvVuTPHcqJJGQ1WhI5KbWlHYz+2+2C/LSEtCw4=
149-
go.einride.tech/aip v0.68.1 h1:16/AfSxcQISGN5z9C5lM+0mLYXihrHbQ1onvYTr93aQ=
150-
go.einride.tech/aip v0.68.1/go.mod h1:XaFtaj4HuA3Zwk9xoBtTWgNubZ0ZZXv9BZJCkuKuWbg=
147+
go.einride.tech/aip v0.73.0 h1:bPo4oqBo2ZQeBKo4ZzLb1kxYXTY1ysJhpvQyfuGzvps=
148+
go.einride.tech/aip v0.73.0/go.mod h1:Mj7rFbmXEgw0dq1dqJ7JGMvYCZZVxmGOR3S4ZcV5LvQ=
151149
go.opencensus.io v0.24.0 h1:y73uSU6J157QMP2kn2r30vwW1A2W2WFwSCGnAVxeaD0=
152150
go.opencensus.io v0.24.0/go.mod h1:vNK8G9p7aAivkbmorf4v+7Hgx+Zs0yY+0fOtgBfjQKo=
153151
go.opentelemetry.io/auto/sdk v1.1.0 h1:cH53jehLUN6UFLY71z+NDOiNJqDdPRaXzTel0sJySYA=

0 commit comments

Comments
 (0)