Commit 01b3bcc
authored
ui: Move query tab & omnibox SQL mode into QueryPage plugin (#5040)
- Create a new registration system to allow plugins to register omnibox
modes.
- Use this registration to move the query mode into the QueryPage
plugin.
- Move everything related to query tabs into the QueryPage plugin.
- Remove addQueryResultsTab() from extensions (extensions are a hack and
are slowly being removed).
- Create new 'Slice Statistics' section in the generic slice details
panel 'ThreadSliceDetailsPanel' to show the average duration of all
slices with the same name, rather than having this open up in a new
query results tab.
- This change is to solve a dependency issue, but I believe it to be a
much more elegant and useful solution.
- In the future, we could replace this with a histogram, but this is out
of scope for this PR.
<img width="704" height="508" alt="image"
src="https://github.com/user-attachments/assets/7d39dc67-67ae-4217-b71e-3ae64e12683e"
/>1 parent 0ac3218 commit 01b3bcc
File tree
139 files changed
+451
-276
lines changed- test/data/ui-screenshots
- aggregation.test.ts
- frametimeline
- gpu-counter
- sched
- slices
- arcvm_trace.test.ts
- ftrace-events
- sched-tracks
- canvas_renderer.test.ts/load-trace-with-canvas-renderer
- chrome_rendering_desktop.test.ts
- expand-browser
- load-trace
- slice-with-flows
- chrome_scroll_jank_plugin.test.ts
- event-latency-track
- scroll-timeline-track
- scroll-timeline-v4-track
- ftrace_tracks_and_tab.test.ts
- ftrace-tab
- ftrace-tracks
- funcgraph_trace.test.ts
- cpu-funcgraph
- thread-funcgraph
- independent_features.test.ts/debuggable-chip
- json_sort_index.test.ts
- load-trace-with-sort-index-metadata
- verify-process-sort-order
- verify-thread-sort-order-within-process
- kernel_trackevent.test.ts/kernel-trackevent-tracks
- load_and_tracks.test.ts
- info-and-stats
- load-trace
- local_cache_key.test.ts/multiple-traces-via-url-and-local-cache-key
- missing_track_names.test.ts/trace-loaded
- perf_event.test.ts/multiple-callstack-tracks
- queries.test.ts
- omnibox-query
- query-page
- startup_commands_allowlist.test.ts
- dev-perfetto-AddDebugCounterTrack-command-test
- dev-perfetto-AddDebugCounterTrackWithPivot-command-test
- dev-perfetto-AddDebugSliceTrack-command-test
- dev-perfetto-AddDebugSliceTrackWithPivot-command-test
- dev-perfetto-AddNoteAtTimestamp-command-test
- dev-perfetto-CollapseTracksByRegex-command-test
- dev-perfetto-CollapseTracksByRegex-with-explicit-name-filtering
- dev-perfetto-CollapseTracksByRegex-with-path-filtering
- dev-perfetto-CopyTracksToWorkspaceByRegex-command-test
- dev-perfetto-CopyTracksToWorkspaceByRegex-with-path-filtering
- dev-perfetto-CopyTracksToWorkspaceByRegexWithAncestors-command-test
- dev-perfetto-CopyTracksToWorkspaceByRegexWithAncestors-with-path-filtering
- dev-perfetto-CreateWorkspace-command-test
- dev-perfetto-ExpandTracksByRegex-command-test
- dev-perfetto-ExpandTracksByRegex-with-explicit-name-filtering
- dev-perfetto-ExpandTracksByRegex-with-path-filtering
- dev-perfetto-PinTracksByRegex-command-test
- dev-perfetto-PinTracksByRegex-with-explicit-name-filtering
- dev-perfetto-PinTracksByRegex-with-path-filtering
- dev-perfetto-RunQuery-command-test
- dev-perfetto-RunQueryAndShowTab-command-test
- dev-perfetto-RunQueryAndShowTab-with-custom-name
- dev-perfetto-SwitchWorkspace-command-test
- table_viewer.test.ts
- Go-to-process
- Go-to-sched
- Go-to-slice
- Go-to-thread-state
- Go-to-thread
- Table-interactions
- track_event_description.test.ts
- Android-log-track-description
- Cpu-thread-scheduling-description
- Ftrace-track-description
- Thread-state-description
- TrackDescriptor-description
- track_event_ordered_tracks.test.ts
- chronological-order
- explicit-order
- lexicographic-tracks
- load-trace
- zoom.test.ts
- zoom-in
- zoom-out
- ui/src
- components
- details
- core_plugins
- dev.perfetto.CoreCommands
- dev.perfetto.TracklUtils
- core
- frontend
- plugins
- com.android.AndroidCujs
- com.android.AndroidPerfTraceCounters
- com.android.AndroidPerf
- com.example.State
- com.google.PerfettoMcp
- dev.perfetto.CriticalPath
- dev.perfetto.DeeplinkQuerystring
- dev.perfetto.ExplorePage
- query_builder
- dev.perfetto.QueryPage
- public
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
139 files changed
+451
-276
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments