Skip to content

Commit 08919e3

Browse files
copybara-service[bot]Perfetto Team
andauthored
Copybara import from Chromium: proto and stdlib changes (#5164)
Copybara import from Chromium: proto and stdlib changes - f2c415a0cea2c069a8b4acafbe2347a0c03b268d Sync feature protos. by Googler <noreply@google.com> - d7825f28a948eed782b55864f738b68061af0643 Sync feature protos. by Googler <noreply@google.com> COPYBARA_IMPORT=Project import generated by Copybara. GitOrigin-RevId: f2c415a0cea2c069a8b4acafbe2347a0c03b268d Co-authored-by: Perfetto Team <copybara-servicebot@google.com>
1 parent be11b13 commit 08919e3

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

protos/third_party/chromium/optimization_guide/common_quality_data.proto

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ message BoundingRect {
433433
// Note: ScrollerInfo is populated for ANNOTATED_PAGE_CONTENT_MODE_DEFAULT. The
434434
// rest of the fields are only populated for
435435
// ANNOTATED_PAGE_CONTENT_MODE_ACTIONABLE_ELEMENTS.
436-
// Next ID: 18
436+
// Next ID: 21
437437
message InteractionInfo {
438438
// Set if the content node is scrollable.
439439
ScrollerInfo scroller_info = 12 [features = { field_presence: EXPLICIT }];
@@ -467,7 +467,10 @@ message InteractionInfo {
467467
features = { field_presence: EXPLICIT }
468468
];
469469

470-
// Whether the content node is focusable.
470+
// Whether the content node is focusable. See also `is_tabbable`.
471+
// A node can be focusable even if it is not tabbable. For
472+
// example, every option in a long listbox might be focusable, but
473+
// only reachable using the arrow keys.
471474
bool is_focusable = 7 [features = { field_presence: EXPLICIT }];
472475

473476
// Whether the content node is draggable.
@@ -520,6 +523,21 @@ message InteractionInfo {
520523
// TODO(linnan): Deprecate is_disabled in favour of the list of reasons.
521524
repeated InteractionDisabledReason interaction_disabled_reasons = 17;
522525

526+
// Whether the content node is tabbable. This is determined by whether the
527+
// node is focusable and has a non-negative computed tab index (usually 0,
528+
// which indicates it fits into the tab cycle in its natural order).
529+
bool is_tabbable = 18 [features = { field_presence: EXPLICIT }];
530+
531+
// Whether the content node has the aria-activedescendant attribute set. This
532+
// attribute is used to indicate which element in a set of child elements is
533+
// currently active.
534+
bool has_aria_activedescendant = 19 [features = { field_presence: EXPLICIT }];
535+
536+
// Secondary-action targets for a container widget. This lets APC represent
537+
// cases like split buttons or tabs with close buttons where both the
538+
// container and the secondary action element are actionable.
539+
repeated int32 aria_action_target_node_ids = 20;
540+
523541
reserved 8, 1, 2, 11;
524542
}
525543

@@ -711,6 +729,11 @@ message SelectOption {
711729

712730
message TableData {
713731
// The name of the table, coming from the caption.
732+
// Note: this field has some quirks for backwards-compatibility reasons:
733+
// 1. It is only populated if the table name is an immediate child of the
734+
// table element. Table names further down in the tree are skipped, leaving
735+
// this field empty.
736+
// 2. The table name also will appear in a separate child text node.
714737
string table_name = 1 [features = { field_presence: EXPLICIT }];
715738

716739
reserved 2, 3, 4;

0 commit comments

Comments
 (0)