Merge pull request #11784 from google/enhancement/11744-add-external-link-icons

nfmohit · web-flow · commit 0f6247dd4d05 · 2025-11-19T00:20:25.000+01:00
diff --git a/assets/js/modules/ads/components/notifications/EnhancedConversionsNotification.js b/assets/js/modules/ads/components/notifications/EnhancedConversionsNotification.js
@@ -68,7 +68,6 @@ export default function EnhancedConversionsNotification( {
 								id={ id }
 								label={ __( 'Learn more', 'google-site-kit' ) }
 								url={ documentationURL }
-								hideExternalIndicator
 							/>
 						),
 					}
diff --git a/assets/js/modules/ads/components/notifications/__snapshots__/EnhancedConversionsNotification.test.js.snap b/assets/js/modules/ads/components/notifications/__snapshots__/EnhancedConversionsNotification.test.js.snap
@@ -46,6 +46,12 @@ exports[`Ads EnhancedConversionsNotification should render the notification 1`]
                   >
                     Learn more
                   </span>
+                  <span
+                    class="googlesitekit-icon-wrapper"
+                    style="margin-left: 5px;"
+                  >
+                    <svg />
+                  </span>
                 </a>
               </p>
             </div>
diff --git a/assets/js/modules/ads/components/settings/EnhancedConversionsSettingsNotice.js b/assets/js/modules/ads/components/settings/EnhancedConversionsSettingsNotice.js
@@ -109,7 +109,6 @@ export default function EnhancedConversionsSettingsNotice( {
 							id={ id }
 							label={ __( 'Learn more', 'google-site-kit' ) }
 							url={ documentationURL }
-							hideExternalIndicator
 						/>
 					),
 				}
diff --git a/assets/js/modules/ads/components/settings/__snapshots__/EnhancedConversionsSettingsNotice.test.js.snap b/assets/js/modules/ads/components/settings/__snapshots__/EnhancedConversionsSettingsNotice.test.js.snap
@@ -34,6 +34,12 @@ exports[`Ads EnhancedConversionsNotification should render the notice 1`] = `
           >
             Learn more
           </span>
+          <span
+            class="googlesitekit-icon-wrapper"
+            style="margin-left: 5px;"
+          >
+            <svg />
+          </span>
         </a>
       </p>
     </div>
diff --git a/assets/js/modules/analytics-4/components/notifications/EnhancedConversionsNotification.js b/assets/js/modules/analytics-4/components/notifications/EnhancedConversionsNotification.js
@@ -82,7 +82,6 @@ export default function EnhancedConversionsNotification( {
 								id={ id }
 								label={ __( 'Learn more', 'google-site-kit' ) }
 								url={ documentationURL }
-								hideExternalIndicator
 							/>
 						),
 					}
diff --git a/assets/js/modules/analytics-4/components/notifications/__snapshots__/EnhancedConversionsNotification.test.js.snap b/assets/js/modules/analytics-4/components/notifications/__snapshots__/EnhancedConversionsNotification.test.js.snap
@@ -46,6 +46,12 @@ exports[`Analytics EnhancedConversionsNotification should render the notificatio
                   >
                     Learn more
                   </span>
+                  <span
+                    class="googlesitekit-icon-wrapper"
+                    style="margin-left: 5px;"
+                  >
+                    <svg />
+                  </span>
                 </a>
               </p>
             </div>
diff --git a/assets/js/modules/analytics-4/components/settings/EnhancedConversionsSettingsNotice.js b/assets/js/modules/analytics-4/components/settings/EnhancedConversionsSettingsNotice.js
@@ -122,7 +122,6 @@ export default function EnhancedConversionsSettingsNotice( {
 							id={ id }
 							label={ __( 'Learn more', 'google-site-kit' ) }
 							url={ documentationURL }
-							hideExternalIndicator
 						/>
 					),
 				}
diff --git a/assets/js/modules/analytics-4/components/settings/__snapshots__/EnhancedConversionsSettingsNotice.test.js.snap b/assets/js/modules/analytics-4/components/settings/__snapshots__/EnhancedConversionsSettingsNotice.test.js.snap
@@ -34,6 +34,12 @@ exports[`Analytics EnhancedConversionsNotification should render the notice 1`]
           >
             Learn more
           </span>
+          <span
+            class="googlesitekit-icon-wrapper"
+            style="margin-left: 5px;"
+          >
+            <svg />
+          </span>
         </a>
       </p>
     </div>

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ export default function EnhancedConversionsNotification( {`
`68`	`68`	`id={ id }`
`69`	`69`	`label={ __( 'Learn more', 'google-site-kit' ) }`
`70`	`70`	`url={ documentationURL }`
`71`		`- hideExternalIndicator`
`72`	`71`	`/>`
`73`	`72`	`),`
`74`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,6 @@ export default function EnhancedConversionsSettingsNotice( {`
`109`	`109`	`id={ id }`
`110`	`110`	`label={ __( 'Learn more', 'google-site-kit' ) }`
`111`	`111`	`url={ documentationURL }`
`112`		`- hideExternalIndicator`
`113`	`112`	`/>`
`114`	`113`	`),`
`115`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,6 @@ export default function EnhancedConversionsNotification( {`
`82`	`82`	`id={ id }`
`83`	`83`	`label={ __( 'Learn more', 'google-site-kit' ) }`
`84`	`84`	`url={ documentationURL }`
`85`		`- hideExternalIndicator`
`86`	`85`	`/>`
`87`	`86`	`),`
`88`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,6 @@ export default function EnhancedConversionsSettingsNotice( {`
`122`	`122`	`id={ id }`
`123`	`123`	`label={ __( 'Learn more', 'google-site-kit' ) }`
`124`	`124`	`url={ documentationURL }`
`125`		`- hideExternalIndicator`
`126`	`125`	`/>`
`127`	`126`	`),`
`128`	`127`	`}`