Skip to content

Commit 1d244bb

Browse files
authored
Merge pull request #1161 from google/fix/345-jsx-follow-up
Fix JSX issue by making condition a boolean.
2 parents a5a2060 + b002056 commit 1d244bb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

assets/js/components/dialog.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ class Dialog extends Component {
6767

6868
const labelledByID = `googlesitekit-dialog-label-${ instanceId }`;
6969
const describedByID = `googlesitekit-dialog-description-${ instanceId }`;
70+
const hasProvides = !! ( provides && provides.length );
7071

7172
return (
7273
<div
@@ -75,7 +76,7 @@ class Dialog extends Component {
7576
role="alertdialog"
7677
aria-modal="true"
7778
aria-labelledby={ title ? labelledByID : undefined }
78-
aria-describedby={ ( provides && provides.length ) ? describedByID : undefined }
79+
aria-describedby={ hasProvides ? describedByID : undefined }
7980
aria-hidden={ dialogActive ? 'false' : 'true' }
8081
tabIndex="-1"
8182
>
@@ -94,7 +95,7 @@ class Dialog extends Component {
9495
{ subtitle }
9596
</p>
9697
}
97-
{ ( provides && provides.length ) &&
98+
{ hasProvides &&
9899
<section id={ describedByID } className="mdc-dialog__content">
99100
<ul className="mdc-list mdc-list--underlined mdc-list--non-interactive">
100101
{ provides.map( ( attribute ) => (

0 commit comments

Comments
 (0)