Ensure has_data requests are cached if WP_Error.

aaemnnosttv · aaemnnosttv · commit 41ee5404a6d8 · 2020-02-18T17:28:30.000+02:00
diff --git a/includes/Modules/Analytics.php b/includes/Modules/Analytics.php
@@ -1286,7 +1286,7 @@ protected function has_data_for_url( $url ) {
 			);
 
 			if ( is_wp_error( $reports ) ) {
-				return false;
+				$reports = array(); // Bypass data check and cache.
 			}
 
 			foreach ( $reports as $report ) {
diff --git a/includes/Modules/Search_Console.php b/includes/Modules/Search_Console.php
@@ -364,7 +364,7 @@ protected function has_data_for_url( $url ) {
 			);
 
 			if ( is_wp_error( $response_rows ) ) {
-				return false;
+				$response_rows = array(); // Bypass data check and cache.
 			}
 
 			foreach ( $response_rows as $data_row ) {

Original file line number	Diff line number	Diff line change
`@@ -1286,7 +1286,7 @@ protected function has_data_for_url( $url ) {`
`1286`	`1286`	`);`
`1287`	`1287`
`1288`	`1288`	`if ( is_wp_error( $reports ) ) {`
`1289`		`- return false;`
	`1289`	`+ $reports = array(); // Bypass data check and cache.`
`1290`	`1290`	`}`
`1291`	`1291`
`1292`	`1292`	`foreach ( $reports as $report ) {`
Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ protected function has_data_for_url( $url ) {`
`364`	`364`	`);`
`365`	`365`
`366`	`366`	`if ( is_wp_error( $response_rows ) ) {`
`367`		`- return false;`
	`367`	`+ $response_rows = array(); // Bypass data check and cache.`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`foreach ( $response_rows as $data_row ) {`