Add TODO annotations to remove manual AMP dev mode fix once AMP plugin has it (for a while).

felixarntz · felixarntz · commit 542219845532 · 2020-02-19T08:56:46.000-08:00
diff --git a/includes/Core/Admin_Bar/Admin_Bar.php b/includes/Core/Admin_Bar/Admin_Bar.php
@@ -82,6 +82,7 @@ function( $wp_admin_bar ) {
 			99
 		);
 
+		// TODO: This can be removed at some point, see https://github.com/ampproject/amp-wp/pull/4001.
 		add_filter( 'amp_dev_mode_element_xpaths', array( $this, 'add_amp_dev_mode' ) );
 
 		$admin_bar_callback = function() {
diff --git a/includes/Core/Assets/Assets.php b/includes/Core/Assets/Assets.php
@@ -732,6 +732,7 @@ private function run_before_print_callbacks( WP_Dependencies $dependencies, arra
 			if ( isset( $this->assets[ $handle ] ) ) {
 				$this->assets[ $handle ]->before_print();
 
+				// TODO: This can be removed at some point, see https://github.com/ampproject/amp-wp/pull/4001.
 				if ( $is_amp && $this->assets[ $handle ] instanceof Script ) {
 					$this->add_extra_script_amp_dev_mode( $handle );
 				}

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ function( $wp_admin_bar ) {`
`82`	`82`	`99`
`83`	`83`	`);`
`84`	`84`
	`85`	`+ // TODO: This can be removed at some point, see https://github.com/ampproject/amp-wp/pull/4001.`
`85`	`86`	`add_filter( 'amp_dev_mode_element_xpaths', array( $this, 'add_amp_dev_mode' ) );`
`86`	`87`
`87`	`88`	`$admin_bar_callback = function() {`
Original file line number	Diff line number	Diff line change
`@@ -732,6 +732,7 @@ private function run_before_print_callbacks( WP_Dependencies $dependencies, arra`
`732`	`732`	`if ( isset( $this->assets[ $handle ] ) ) {`
`733`	`733`	`$this->assets[ $handle ]->before_print();`
`734`	`734`
	`735`	`+ // TODO: This can be removed at some point, see https://github.com/ampproject/amp-wp/pull/4001.`
`735`	`736`	`if ( $is_amp && $this->assets[ $handle ] instanceof Script ) {`
`736`	`737`	`$this->add_extra_script_amp_dev_mode( $handle );`
`737`	`738`	`}`