Merge pull request #11823 from google/enhancement/11064-tagmanager-confirm-changes-button-to-save

eugene-manuilov · web-flow · commit 66f382a75175 · 2025-11-24T23:13:43.000+02:00
Prevent "Confirm changes" button prematurely changing to "Save"
diff --git a/assets/js/components/settings/SettingsActiveModule/FooterPrimaryAction.js b/assets/js/components/settings/SettingsActiveModule/FooterPrimaryAction.js
@@ -71,7 +71,7 @@ export default function FooterPrimaryAction( {
 						isSaving={ isSaving }
 					>
 						{ ( () => {
-							if ( haveSettingsChanged ) {
+							if ( haveSettingsChanged || isSaving ) {
 								return __(
 									'Confirm changes',
 									'google-site-kit'

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ export default function FooterPrimaryAction( {`
`71`	`71`	`isSaving={ isSaving }`
`72`	`72`	`>`
`73`	`73`	`{ ( () => {`
`74`		`- if ( haveSettingsChanged ) {`
	`74`	`+ if ( haveSettingsChanged \|\| isSaving ) {`
`75`	`75`	`return __(`
`76`	`76`	`'Confirm changes',`
`77`	`77`	`'google-site-kit'`