-
Notifications
You must be signed in to change notification settings - Fork 328
[11722] Add GA event tracking for the Analytics setup screen. #11776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
techanvil
merged 12 commits into
develop
from
enhancement/11722-ga-event-analytics-setup
Nov 25, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f8b25f2
Add GA event tracking for the Analytics setup screen.
ankitrox 6b6aa0c
Remove redundant code.
ankitrox de48db5
Fix: reference error.
ankitrox c18d236
Merge branch 'develop' into enhancement/11722-ga-event-analytics-setup.
ankitrox 5daa659
Optimize the conditional statement.
ankitrox 00d55fe
Merge branch 'develop' into enhancement/11722-ga-event-analytics-setup.
ankitrox 54cd414
Address CR feedback.
ankitrox 0c0865f
Merge branch 'develop' into enhancement/11722-ga-event-analytics-setup.
ankitrox 66a9748
Address MR feedback.
ankitrox 8867812
Fix: JS test.
ankitrox 8d9b9ee
Add afterEach.
ankitrox 5087bf3
Update snapshot.
ankitrox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why you added
isInitialSetupFlowandviewContextto the dependency array here but not inModuleSetup.js? Doesn't seem like a big deal, but I'm wondering if we can keep things consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch @abdelmalekkkkk , thanks for spotting it.
I've added it now.