Enhancement/11435 Create EmailReporting Settings Analytics Disconnected notice #11831
+458
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook is ready:
|
|
Build files for 3e286ab are ready:
|
|
Size Change: +459 B (+0.02%) Total Size: 2.19 MB ℹ️ View Unchanged
|
zutigrm
requested changes
Nov 25, 2025
Collaborator
There was a problem hiding this comment.
Thanks @jimmymadon looking good in overall, I left you few comments
Collaborator
There was a problem hiding this comment.
We can complete the coverage by including two more cases to verify that notice is not showing in these scenarios:
does not render when Analytics is activedoes not render if Analytics was once connected
Collaborator
There was a problem hiding this comment.
We usually preload settings, it will be beneficial to include new route to the googlesitekit_apifetch_preload_paths hook together with existing /core/user/data/email-reporting-settings prefetched route
| $this->settings = $settings; | ||
| public function __construct( Email_Reporting_Settings $settings, Options $options ) { | ||
| $this->settings = $settings; | ||
| $this->was_analytics_4_connected = new Was_Analytics_4_Connected( $options ); |
Collaborator
There was a problem hiding this comment.
This is not the best place to instantiate the Was_Analytics_4_Connected, we should instantiate it in the constructor of Google\Site_Kit\Core\Email_Reporting\Email_Reporting and pass it as DI to the REST_Email_Reporting_Controller when instantiating it, so only an instance is received and set as class property here
| * @access private | ||
| * @ignore | ||
| */ | ||
| class Was_Analytics_4_Connected extends Setting { |
Collaborator
There was a problem hiding this comment.
Lets include get_default method to return false by default to value is always returned/set and get_sanitize_callback with return 'boolval' to have established pattern of sanitising fields on save
Comment on lines
+545
to
+546
| $was_analytics_4_connected = new Was_Analytics_4_Connected( $this->options ); | ||
| $was_analytics_4_connected->set( true ); |
Collaborator
There was a problem hiding this comment.
Although I like the simplified approach by marking the settings directly on deactivation instead of listening to the settings change, instantiating Email_Reporting settings cross namespace this way isn't the best design. I would propose we create a new action here, for example do_action('googlesitekit_analytics_4_on_deactivation') or something similar and then hook into it from Google\Site_Kit\Core\Email_Reporting\Email_Reporting::register where Was_Analytics_4_Connected instance is already set.
I would like to get @eugene-manuilov thoughts on this too before we add a new hook here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
<EmailReportingSettingsAnalyticsDisconnectedNotice>settings analytics disconnected inline notice component #11435Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist