Skip to content

Commit 4f272d3

Browse files
committed
Handle newly added lifecyle_stage.DISABLED
PiperOrigin-RevId: 345814659
1 parent db38612 commit 4f272d3

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

struct2tensor/expression_impl/promote.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,11 @@ def _lifecycle_stage_number(a) -> int:
213213
An integer that corresponds to the lifecycle stage of 'a'.
214214
"""
215215
stages = [
216-
schema_pb2.LifecycleStage.DEPRECATED, schema_pb2.LifecycleStage.PLANNED,
217-
schema_pb2.LifecycleStage.ALPHA, schema_pb2.LifecycleStage.DEBUG_ONLY,
218-
None, schema_pb2.LifecycleStage.UNKNOWN_STAGE,
219-
schema_pb2.LifecycleStage.BETA, schema_pb2.LifecycleStage.PRODUCTION
216+
schema_pb2.LifecycleStage.DEPRECATED, schema_pb2.LifecycleStage.DISABLED,
217+
schema_pb2.LifecycleStage.PLANNED, schema_pb2.LifecycleStage.ALPHA,
218+
schema_pb2.LifecycleStage.DEBUG_ONLY, None,
219+
schema_pb2.LifecycleStage.UNKNOWN_STAGE, schema_pb2.LifecycleStage.BETA,
220+
schema_pb2.LifecycleStage.PRODUCTION
220221
]
221222
return stages.index(a)
222223

struct2tensor/expression_impl/promote_test.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ def test_promote_with_schema_dense_parent(self):
106106
def test_lifecycle_stage(self):
107107
# Stages have the following priority, from lowest to highest:
108108
# schema_pb2.LifecycleStage.DEPRECATED
109+
# schema_pb2.LifecycleStage.DISABLED
109110
# schema_pb2.LifecycleStage.PLANNED,
110111
# schema_pb2.LifecycleStage.ALPHA
111112
# schema_pb2.LifecycleStage.DEBUG_ONLY,
@@ -139,7 +140,17 @@ def _check_lifecycle_stage(a, b):
139140
self.assertEqual(
140141
schema_pb2.LifecycleStage.DEPRECATED,
141142
_check_lifecycle_stage(schema_pb2.LifecycleStage.DEPRECATED,
142-
schema_pb2.LifecycleStage.PLANNED))
143+
schema_pb2.LifecycleStage.DISABLED))
144+
self.assertEqual(
145+
schema_pb2.LifecycleStage.DEPRECATED,
146+
_check_lifecycle_stage(schema_pb2.LifecycleStage.DISABLED,
147+
schema_pb2.LifecycleStage.DEPRECATED))
148+
149+
self.assertEqual(
150+
schema_pb2.LifecycleStage.DISABLED,
151+
_check_lifecycle_stage(schema_pb2.LifecycleStage.PLANNED,
152+
schema_pb2.LifecycleStage.DISABLED))
153+
143154
self.assertEqual(
144155
schema_pb2.LifecycleStage.DEPRECATED,
145156
_check_lifecycle_stage(schema_pb2.LifecycleStage.PLANNED,

0 commit comments

Comments
 (0)