Skip to content

Commit c0855b9

Browse files
ckennellycopybara-github
authored andcommitted
Inline deprecated functions.
PiperOrigin-RevId: 767700810 Change-Id: I5d767180367330276209042f80c984868cb427b2
1 parent 61b60f4 commit c0855b9

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

tcmalloc/testing/profile_drop_frames_test.cc

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ inline ABSL_ATTRIBUTE_ALWAYS_INLINE void* wrap_memalign(size_t size) {
147147

148148
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void* wrap_size_returning_operator_new(
149149
size_t size) {
150-
return tcmalloc_size_returning_operator_new(size).p;
150+
return __size_returning_new(size).p;
151151
}
152152

153153
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
@@ -157,9 +157,7 @@ wrap_size_returning_operator_new_nothrow(size_t size) {
157157

158158
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
159159
wrap_size_returning_operator_new_hot_cold(size_t size) {
160-
return tcmalloc_size_returning_operator_new_hot_cold(size,
161-
tcmalloc::hot_cold_t(0))
162-
.p;
160+
return __size_returning_new_hot_cold(size, tcmalloc::hot_cold_t(0)).p;
163161
}
164162

165163
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
@@ -171,9 +169,7 @@ wrap_size_returning_operator_new_hot_cold_nothrow(size_t size) {
171169

172170
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
173171
wrap_size_returning_operator_new_aligned(size_t size) {
174-
return tcmalloc_size_returning_operator_new_aligned(size,
175-
std::align_val_t(64))
176-
.p;
172+
return __size_returning_new_aligned(size, std::align_val_t(64)).p;
177173
}
178174

179175
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
@@ -185,8 +181,8 @@ wrap_size_returning_operator_new_aligned_nothrow(size_t size) {
185181

186182
inline ABSL_ATTRIBUTE_ALWAYS_INLINE void*
187183
wrap_size_returning_operator_new_aligned_hot_cold(size_t size) {
188-
return tcmalloc_size_returning_operator_new_aligned_hot_cold(
189-
size, std::align_val_t(64), tcmalloc::hot_cold_t(0))
184+
return __size_returning_new_aligned_hot_cold(size, std::align_val_t(64),
185+
tcmalloc::hot_cold_t(0))
190186
.p;
191187
}
192188

tcmalloc/testing/tcmalloc_test.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ TEST(TCMallocTest, GetEstimatedAllocatedSizeHotCold) {
823823
MallocExtension::GetEstimatedAllocatedSize(size, hot_cold);
824824
ASSERT_GE(rounded, size);
825825
auto [ptr, allocated_size] =
826-
tcmalloc_size_returning_operator_new_hot_cold(size, hot_cold);
826+
__size_returning_new_hot_cold(size, hot_cold);
827827
ASSERT_EQ(rounded, allocated_size);
828828
free(ptr);
829829
}
@@ -1004,14 +1004,14 @@ class TcmallocSizedNewTest
10041004
(align_needed << 2) | (hot_cold_needed << 1) | nothrow_needed;
10051005
switch (encoding) {
10061006
case 0b000:
1007-
sro_new_ = tcmalloc_size_returning_operator_new;
1007+
sro_new_ = __size_returning_new;
10081008
break;
10091009
case 0b001:
10101010
sro_new_ = tcmalloc_size_returning_operator_new_nothrow;
10111011
break;
10121012
case 0b010:
10131013
sro_new_ = [this](size_t size) {
1014-
return tcmalloc_size_returning_operator_new_hot_cold(size, hot_cold_);
1014+
return __size_returning_new_hot_cold(size, hot_cold_);
10151015
};
10161016
break;
10171017
case 0b011:
@@ -1022,7 +1022,7 @@ class TcmallocSizedNewTest
10221022
break;
10231023
case 0b100:
10241024
sro_new_ = [this](size_t size) {
1025-
return tcmalloc_size_returning_operator_new_aligned(size, align_);
1025+
return __size_returning_new_aligned(size, align_);
10261026
};
10271027
break;
10281028
case 0b101:
@@ -1033,8 +1033,7 @@ class TcmallocSizedNewTest
10331033
break;
10341034
case 0b110:
10351035
sro_new_ = [this](size_t size) {
1036-
return tcmalloc_size_returning_operator_new_aligned_hot_cold(
1037-
size, align_, hot_cold_);
1036+
return __size_returning_new_aligned_hot_cold(size, align_, hot_cold_);
10381037
};
10391038
break;
10401039
case 0b111:
@@ -1162,7 +1161,7 @@ TEST(SizedDeleteTest, SizedOperatorDelete) {
11621161
enum DeleteSize { kSize, kCapacity, kHalfway };
11631162
for (size_t size = 0; size < kMaxSize; ++size) {
11641163
for (auto delete_size : {kSize, kCapacity, kHalfway}) {
1165-
sized_ptr_t res = tcmalloc_size_returning_operator_new(size);
1164+
sized_ptr_t res = __size_returning_new(size);
11661165
switch (delete_size) {
11671166
case kSize:
11681167
::operator delete(res.p, size);
@@ -1471,7 +1470,7 @@ TEST(HotColdTest, SizeReturningHotColdNew) {
14711470
const size_t requested = absl::LogUniform<size_t>(rng, kSmall, kLarge);
14721471
const uint8_t label = absl::Uniform<uint8_t>(rng, 0, 255);
14731472

1474-
auto [ptr, actual] = tcmalloc_size_returning_operator_new_hot_cold(
1473+
auto [ptr, actual] = __size_returning_new_hot_cold(
14751474
requested, static_cast<hot_cold_t>(label));
14761475
ASSERT_GE(actual, requested);
14771476

@@ -1619,10 +1618,10 @@ TEST(MallocExtension, SizeReturningNewAndSizedDelete) {
16191618
ScopedGuardedSamplingInterval gs(-1);
16201619

16211620
for (int i = 0; i < 100; ++i) {
1622-
tcmalloc::sized_ptr_t sized_ptr = tcmalloc_size_returning_operator_new(i);
1621+
tcmalloc::sized_ptr_t sized_ptr = __size_returning_new(i);
16231622
::operator delete(sized_ptr.p, sized_ptr.n);
16241623
for (int j = i, end = sized_ptr.n; j < end; ++j) {
1625-
sized_ptr = tcmalloc_size_returning_operator_new(i);
1624+
sized_ptr = __size_returning_new(i);
16261625
EXPECT_EQ(end, sized_ptr.n) << i << "," << j;
16271626
::operator delete(sized_ptr.p, j);
16281627
}

0 commit comments

Comments
 (0)