Revert to mode 0666 for "file" kvstore.

Fixes: #220
PiperOrigin-RevId: 735593374
Change-Id: I0fc07212f5b676d590062377d0d5171956deee9a

Author: laramiel

tensorstore/internal/os/file_util.h

@@ -293,6 +293,42 @@ inline absl::Time GetMTime(const FileInfo& info) {
 #endif
 }
 
+/// Returns the creation time.
+inline absl::Time GetCTime(const FileInfo& info) {
+#ifdef _WIN32
+  // Windows FILETIME is the number of 100-nanosecond intervals since the
+  // Windows epoch (1601-01-01) which is 11644473600 seconds before the unix
+  // epoch (1970-01-01).
+  uint64_t windowsTicks =
+      (static_cast<uint64_t>(info.ftCreationTime.dwHighDateTime) << 32) |
+      static_cast<uint64_t>(info.ftCreationTime.dwLowDateTime);
+
+  return absl::UnixEpoch() +
+         absl::Seconds((windowsTicks / 10000000) - 11644473600ULL) +
+         absl::Nanoseconds(windowsTicks % 10000000);
+#else
+#if defined(__APPLE__)
+  const struct ::timespec t = info.st_ctimespec;
+#else
+  const struct ::timespec t = info.st_ctim;
+#endif
+  return absl::FromTimeT(t.tv_sec) + absl::Nanoseconds(t.tv_nsec);
+#endif
+}
+
+/// Returns the mode bits.
+inline uint32_t GetMode(const FileInfo& info) {
+#ifdef _WIN32
+  if (info.dwFileAttributes & FILE_ATTRIBUTE_READONLY) {
+    return 0444;  // read-only
+  } else {
+    return 0666;  // read/write
+  }
+#else
+  return info.st_mode;
+#endif
+}
+
 /// --------------------------------------------------------------------------
 
 /// Opens a directory.

tensorstore/internal/os/file_util_posix.cc

@@ -228,7 +228,7 @@ Result<UniqueFileDescriptor> OpenFileWrapper(const std::string& path,
   FileDescriptor fd = FileDescriptorTraits::Invalid();
   const auto attempt_open = [&] {
     PotentiallyBlockingRegion region;
-    fd = ::open(path.c_str(), static_cast<int>(flags) | O_CLOEXEC, 0660);
+    fd = ::open(path.c_str(), static_cast<int>(flags) | O_CLOEXEC, 0666);
   };
 #ifndef __APPLE__
   attempt_open();

tensorstore/internal/os/file_util_test.cc

@@ -40,10 +40,12 @@ using ::tensorstore::internal_os::DeleteFile;
 using ::tensorstore::internal_os::DeleteOpenFile;
 using ::tensorstore::internal_os::FileInfo;
 using ::tensorstore::internal_os::FsyncFile;
+using ::tensorstore::internal_os::GetCTime;
 using ::tensorstore::internal_os::GetDefaultPageSize;
 using ::tensorstore::internal_os::GetDeviceId;
 using ::tensorstore::internal_os::GetFileId;
 using ::tensorstore::internal_os::GetFileInfo;
+using ::tensorstore::internal_os::GetMode;
 using ::tensorstore::internal_os::GetMTime;
 using ::tensorstore::internal_os::GetSize;
 using ::tensorstore::internal_os::IsDirSeparator;
@@ -86,7 +88,6 @@ TEST(FileUtilTest, Basics) {
 
     EXPECT_THAT(WriteCordToFile(f->get(), absl::Cord("foo")), IsOkAndHolds(3));
     EXPECT_THAT(WriteToFile(f->get(), "bar", 3), IsOkAndHolds(3));
-
     EXPECT_THAT(FsyncFile(f->get()), IsOk());
   }
 
@@ -95,6 +96,7 @@ TEST(FileUtilTest, Basics) {
     char buf[16];
     auto f = OpenExistingFileForReading(foo_txt);
     EXPECT_THAT(f, IsOk());
+
     EXPECT_THAT(ReadFromFile(f->get(), buf, 3, 0), IsOkAndHolds(3));
 
     // Check the file info
@@ -106,6 +108,8 @@ TEST(FileUtilTest, Basics) {
     EXPECT_THAT(GetFileId(info), ::testing::Ne(0));
     EXPECT_THAT(GetDeviceId(info), ::testing::Ne(0));
     EXPECT_THAT(GetMTime(info), ::testing::Ge(now));
+    EXPECT_THAT(GetCTime(info), ::testing::Ge(now));
+    EXPECT_THAT(GetMode(info) & 0600, ::testing::Eq(0600));
 
     EXPECT_THAT(RenameOpenFile(f->get(), foo_txt, renamed_txt), IsOk());
   }

tensorstore/internal/os/file_util_win.cc

@@ -177,16 +177,6 @@ std::string_view GetDirName(std::string_view path) {
   return path.substr(0, i);
 }
 
-#if 0
-Result<DWORD> GetFileAttributes(const std::wstring& filename) {
-  if (const DWORD attrs = ::GetFileAttributesW(filename.c_str());
-      attrs != INVALID_FILE_ATTRIBUTES) {
-    return attrs;
-  }
-  return StatusFromOsError(::GetLastError(), "GetFileAttributesW failed");
-}
-#endif
-
 void UnlockWin32Lock(FileDescriptor fd) {
   LoggedTraceSpan tspan(__func__, detail_logging.Level(1), {{"handle", fd}});