Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 10efad5

Browse files
authored
Merge pull request #496 from trevh3/fix_MaxVersion
py2/3 compatibility for _MaxVersion function in transitfeed/util.py
2 parents 75a17aa + e7f1877 commit 10efad5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

transitfeed/util.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,12 +226,12 @@ def CheckVersion(problems, latest_version=None):
226226

227227

228228
def _MaxVersion(versions):
229-
versions = filter(None, versions)
230-
versions.sort(lambda x,y: -cmp([int(item) for item in x.split('.')],
231-
[int(item) for item in y.split('.')]))
232-
if len(versions) > 0:
233-
return versions[0]
229+
versions = [item for item in versions if item]
230+
if len(versions) == 0:
231+
return None
234232

233+
version_tuple = lambda x: tuple(int(item) for item in x.split('.'))
234+
return max(versions, key=version_tuple)
235235

236236
OUTPUT_ENCODING = 'utf-8'
237237

0 commit comments

Comments
 (0)