Skip to content

Commit 3efdc7e

Browse files
authored
PostgreSQL quota manager: Use SELECT(*) instead of ANALYZE up to 10,000 rows instead of 1,000. (#3813)
* PostgreSQL quota manager: Use SELECT(*) instead of ANALYZE up to 10,000 rows instead of 1,000. * Update CHANGELOG.md
1 parent 9c4d8ac commit 3efdc7e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
* Fix leader resignation during a graceful shutdown by @osmman in https://github.com/google/trillian/pull/3790
77
* Add optional gRPC message size limit via `--max_msg_size_bytes` flag by @fghanmi in https://github.com/google/trillian/pull/3801
88

9+
### Storage
10+
11+
* PostgreSQL quota manager: Use SELECT(*) instead of ANALYZE up to 10,000 rows instead of 1,000 by @robstradling in https://github.com/google/trillian/pull/3813
12+
913
## v1.7.2
1014

1115
* Recommended go version for development: 1.23

storage/postgresql/schema/storage.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ DECLARE
153153
n bigint;
154154
plan jsonb;
155155
BEGIN
156-
EXECUTE 'SELECT count(1) FROM (SELECT 1 FROM ' || table_name || ' LIMIT 1000) sub' INTO n;
157-
IF n < 1000 THEN
156+
EXECUTE 'SELECT count(1) FROM (SELECT 1 FROM ' || table_name || ' LIMIT 10000) sub' INTO n;
157+
IF n < 10000 THEN
158158
RETURN n;
159159
ELSE
160160
EXECUTE 'ANALYZE ' || table_name || ';EXPLAIN (FORMAT JSON) SELECT * FROM ' || table_name INTO plan;

0 commit comments

Comments
 (0)