Fix handling of strings with null character.

allanrenucci · copybara-github · commit f04923bc1e6d · 2025-04-28T00:51:56.000-07:00
PiperOrigin-RevId: 752197087
diff --git a/tsl/platform/tstring.h b/tsl/platform/tstring.h
@@ -212,7 +212,7 @@ class tstring {
   // Support for absl::StrCat() etc.
   template <typename Sink>
   friend void AbslStringify(Sink& sink, const tstring& str) {
-    absl::Format(&sink, "%s", str.data());
+    absl::Format(&sink, "%s", absl::string_view(str));
   }
 };
 
diff --git a/tsl/platform/tstring_test.cc b/tsl/platform/tstring_test.cc
@@ -266,6 +266,8 @@ TEST(TF_TStringTest, Conversion) {
 
   EXPECT_STREQ(kLongString, s53.data());
   EXPECT_EQ(kLongStringLen, s53.size());
+
+  EXPECT_EQ(std::string("\0a", 2), absl::StrCat(tstring("\0a", 2)));
 }
 
 TEST(TF_TStringTest, Allocation) {

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ class tstring {`
`212`	`212`	`// Support for absl::StrCat() etc.`
`213`	`213`	`template <typename Sink>`
`214`	`214`	`friend void AbslStringify(Sink& sink, const tstring& str) {`
`215`		`- absl::Format(&sink, "%s", str.data());`
	`215`	`+ absl::Format(&sink, "%s", absl::string_view(str));`
`216`	`216`	`}`
`217`	`217`	`};`
`218`	`218`
Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,8 @@ TEST(TF_TStringTest, Conversion) {`
`266`	`266`
`267`	`267`	`EXPECT_STREQ(kLongString, s53.data());`
`268`	`268`	`EXPECT_EQ(kLongStringLen, s53.size());`
	`269`	`+`
	`270`	`+ EXPECT_EQ(std::string("\0a", 2), absl::StrCat(tstring("\0a", 2)));`
`269`	`271`	`}`
`270`	`272`
`271`	`273`	`TEST(TF_TStringTest, Allocation) {`