Skip to content

Commit e4bcbfe

Browse files
jiangyangmuThe tunix Authors
authored andcommitted
Fix first_micro_batch_rollout_time
PiperOrigin-RevId: 834982334
1 parent 7852510 commit e4bcbfe

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/perf/export_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def test_export_grpo_metrics_rollout_1_actor_2_reference_2(
161161
"perf/global_step_time": 1.3,
162162
"perf/weight_sync_time": 0.1,
163163
"perf/rollout_idle_time": 0.69,
164-
"perf/first_micro_batch_rollout_time": 0.3,
164+
"perf/first_micro_batch_rollout_time": 0.41,
165165
"perf/sum/rollout_time": 0.11,
166166
"perf/sum/refer_inference_time": 0.11,
167167
"perf/sum/actor_train_grad_time": 0.11,

tunix/perf/export.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def _grpo_metrics_rollout_1_actor_2_reference_2(
202202
]
203203

204204
first_micro_batch_rollout_time: float = (
205-
rollout_spans[0].begin - global_step_group.begin
205+
rollout_spans[0].end - global_step_group.begin
206206
)
207207

208208
# append [0.0] to make size equal to micro batch

0 commit comments

Comments
 (0)