Resolve review feedback

Author: lhchavez

autoload/codefmt/prettier.vim

@@ -49,11 +49,15 @@ function! codefmt#prettier#GetFormatter() abort
           \ string(l:Prettier_options))
     endif
     let l:cmd = [s:plugin.Flag('prettier_executable'), '--stdin', '--no-color']
+
+    " prettier is able to automatically choose the best parser if the filepath
+    " is provided. Otherwise, fall back to the previous default: babylon.
     if @% == ""
       call extend(l:cmd, ['--parser', 'babylon'])
     else
       call extend(l:cmd, ['--stdin-filepath', @%])
     endif
+
     call maktaba#ensure#IsNumber(a:startline)
     call maktaba#ensure#IsNumber(a:endline)
 

doc/codefmt.txt

@@ -60,6 +60,35 @@ Default: 'yapf' `
 The path to the gn executable.
 Default: 'gn' `
 
+                                               *codefmt:buildifier_executable*
+The path to the buildifier executable.
+Default: 'buildifier' `
+
+                                              *codefmt:google_java_executable*
+The path to the google-java executable.  Generally, this should have the form:
+`java -jar /path/to/google-java`
+Default: 'google-java-format' `
+
+                                                       *codefmt:shfmt_options*
+Command line arguments to to feed shfmt. Either a list or callable that takes
+no args and returns a list with command line arguments. By default, uses the
+Google's style. See https://github.com/mvdan/sh for details.
+Default: ['-i', '2', '-sr', '-ci'] `
+
+                                                    *codefmt:shfmt_executable*
+The path to the shfmt executable.
+Default: 'shfmt' `
+
+                                                    *codefmt:prettier_options*
+Command line arguments to to feed prettier. Either a list or callable that
+takes no args and returns a list with command line arguments.
+Default: [ '--single-quote', '--trailing-comma=all', '--arrow-parens=always',
+  '--print-width=80'] `
+
+                                                 *codefmt:prettier_executable*
+The path to the prettier executable.
+Default: 'prettier' `
+
                                                     *codefmt:plugin[autocmds]*
 Configures whether plugin/autocmds.vim should be loaded.
 Default: 1 `
@@ -99,6 +128,7 @@ none is explicitly supplied via an explicit arg to |:FormatCode| or the
 plugins are enabled or what other software is installed on your system.
 
 The current list of defaults by filetype is:
+  * bzl (Bazel): buildifier
   * c, cpp, proto, javascript, typescript: clang-format
   * go: gofmt
   * python: autopep8, yapf

instant/flags.vim

@@ -108,7 +108,9 @@ call s:plugin.Flag('shfmt_executable', 'shfmt')
 ""
 " Command line arguments to to feed prettier. Either a list or callable that
 " takes no args and returns a list with command line arguments.
-call s:plugin.Flag('prettier_options', ['--single-quote', '--trailing-comma=all', '--arrow-parens=always', '--print-width=80'])
+call s:plugin.Flag('prettier_options', [
+    \ '--single-quote', '--trailing-comma=all',
+    \ '--arrow-parens=always', '--print-width=80'])
 
 ""
 " The path to the prettier executable.

vroom/prettier.vroom

@@ -66,11 +66,12 @@ Errors are reported using the quickfix list.
 
   :FormatCode prettier
   ! prettier .*2> (.*)
-  $ echo '[error] stdin: SyntaxError: Unexpected token (2:1)' >\1 (command)
-  $ echo '[error]   1 | function foo() {' >>\1 (command)
-  $ echo '[error] > 2 |' >>\1 (command)
-  $ echo '[error]     | ^' >>\1 (command)
   $ 2 (status)
+  $ echo >\1 ' (command)
+  |[error] stdin: SyntaxError: Unexpected token (2:1)\n
+  |[error]   1 | function foo() {\n
+  |[error] > 2 |\n
+  |[error]     | ^'
   function foo() {
   @end
   :echomsg line('.') . ',' . col('.')