Skip to content

Commit 1013ffb

Browse files
authored
Test with firefox on macos again (#163)
* Try to find where firefox is installed * Update test.yml * Manually specify firefox location for package:test on macos
1 parent c1ca4f4 commit 1013ffb

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

.github/workflows/test.yml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,14 @@ jobs:
7777
# --driver=test_driver/integration_test.dart \
7878
# --target=integration_test/webcrypto_test.dart \
7979
# -d chrome
80-
# TODO: Enable firefox testing on MacOS when it works
81-
- run: flutter pub run test -p vm,chrome
80+
- uses: browser-actions/setup-firefox@v1
81+
- name: flutter pub run test -p vm,chrome,firefox
82+
shell: bash
83+
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
84+
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
85+
run: |
86+
export FIREFOX_EXECUTABLE="$(which firefox)"
87+
flutter pub run test -p vm,chrome,firefox
8288
macos-15:
8389
name: webcrypto on macOS 15 desktop / Chrome
8490
runs-on: macos-15 # Test with xcode 16
@@ -98,8 +104,14 @@ jobs:
98104
- run: flutter test integration_test/webcrypto_test.dart -d macos
99105
working-directory: ./example
100106
# TODO: Enable chromedriver testing on MacOS when it works reliably
101-
# TODO: Enable firefox testing on MacOS when it works
102-
- run: flutter pub run test -p vm,chrome
107+
- uses: browser-actions/setup-firefox@v1
108+
- name: flutter pub run test -p vm,chrome,firefox
109+
shell: bash
110+
# Remove FIREFOX_EXECUTABLE override when flutter upgrades past package:test 1.25.8
111+
# Issue is fixed in https://github.com/dart-lang/test/pull/2276
112+
run: |
113+
export FIREFOX_EXECUTABLE="$(which firefox)"
114+
flutter pub run test -p vm,chrome,firefox
103115
windows:
104116
name: webcrypto on Windows desktop / Chrome / Firefox
105117
runs-on: windows-latest

0 commit comments

Comments
 (0)