Skip to content

Commit f4de7c1

Browse files
authored
Disable chromedriver tests on macos (#155)
This is effectively integration tests for Chrome on MacOS. These tests shouldn't really be necessary, since we tests chrome compatibility in multiple ways. For unknown reasons these tests are unreliable on MacOS. They were constantly timing out for no good reason.
1 parent 58bc71a commit f4de7c1

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/test.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,15 @@ jobs:
5656
- run: flutter test --platform chrome
5757
- run: flutter test integration_test/webcrypto_test.dart -d macos
5858
working-directory: ./example
59-
- uses: nanasess/setup-chromedriver@v2
60-
- name: Run integration_test with chromedriver
61-
working-directory: ./example
62-
run: |
63-
../tool/with-chromedriver.sh flutter drive \
64-
--driver=test_driver/integration_test.dart \
65-
--target=integration_test/webcrypto_test.dart \
66-
-d chrome
59+
# TODO: Enable chromdriver testing on MacOS when it works reliably
60+
#- uses: nanasess/setup-chromedriver@v2
61+
#- name: Run integration_test with chromedriver
62+
# working-directory: ./example
63+
# run: |
64+
# ../tool/with-chromedriver.sh flutter drive \
65+
# --driver=test_driver/integration_test.dart \
66+
# --target=integration_test/webcrypto_test.dart \
67+
# -d chrome
6768
- run: flutter pub run test -p vm,chrome # TODO: Enable firefox if it works
6869
windows:
6970
name: webcrypto on Windows desktop / Chrome / Firefox

0 commit comments

Comments
 (0)