Skip to content

Commit 8ee59ef

Browse files
grebecopybara-github
authored andcommitted
Migrate xls::down_cast to use absl::down_cast.
The xls::down_cast functions are now implemented as direct calls to absl::down_cast and are marked with ABSL_DEPRECATE_AND_INLINE. Note that we also bump our abseil dep to grab a newer version with absl::down_cast. PiperOrigin-RevId: 866676858
1 parent 7381ad8 commit 8ee59ef

File tree

6 files changed

+81
-13321
lines changed

6 files changed

+81
-13321
lines changed

MODULE.bazel

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,14 @@ use_repo(llvm, "llvm_toolchain")
1616
register_toolchains("@llvm_toolchain//:all")
1717

1818
# Python toolchain
19-
# TODO: https://github.com/google/xls/issues/2941 - Update to more recent version once we've
20-
# migrated to Bazel 8.
21-
# We need to pin to 1.0.0 until moving to Bazel 8, or else we run into missing py_library attribute
22-
# (e.g. pyi_srcs) errors in pip dependencies.
23-
bazel_dep(name = "rules_python", version = "1.0.0")
24-
25-
# or-tools otherwise forces us to 1.2.0.
26-
single_version_override(
27-
module_name = "rules_python",
28-
version = "1.0.0",
29-
)
19+
# TODO: https://github.com/google/xls/issues/2941 - revisit versioning once we're on bazel 8.
20+
# We previously pinned to 1.0.0 until moving to Bazel 8, or else we ran into missing py_library
21+
# attribute (e.g. pyi_srcs) errors in pip dependencies. More recent versions of rules_python seem
22+
# to fix this, only to have a new problem in that grpc requires a "preview" release of python 3.14
23+
# that later rules_python releases dropped. This was fixed in grpc/grpc#41278 but doesn't seem to
24+
# have made it into the latest release. For now, we stick to the same version of rules_python as
25+
# grpc.
26+
bazel_dep(name = "rules_python", version = "1.5.4")
3027

3128
PYTHON_VERSION = "3.12"
3229

@@ -56,14 +53,14 @@ use_repo(pip, "xls_pip_deps")
5653

5754
# Root module dependencies.
5855
# Note: some WORKSPACE dependencies still require repo_name aliases.
59-
bazel_dep(name = "abseil-cpp", version = "20250814.1", repo_name = "com_google_absl")
56+
bazel_dep(name = "abseil-cpp", version = "20260107.0", repo_name = "com_google_absl")
6057
bazel_dep(name = "abseil-py", version = "2.1.0")
6158
bazel_dep(name = "bazel_features", version = "1.30.0")
6259
bazel_dep(name = "bazel_skylib", version = "1.8.1")
6360
bazel_dep(name = "boringssl", version = "0.20250114.0")
6461
bazel_dep(name = "cppitertools", version = "2.2")
6562
bazel_dep(name = "googleapis", version = "0.0.0-20260109-6145b5ff")
66-
bazel_dep(name = "grpc", version = "1.74.1")
63+
bazel_dep(name = "grpc", version = "1.78.0")
6764
bazel_dep(name = "linenoise", version = "2.0.0")
6865
bazel_dep(name = "nlohmann_json", version = "3.11.3.bcr.1")
6966
bazel_dep(name = "or-tools", version = "9.12", repo_name = "com_google_ortools")

0 commit comments

Comments
 (0)