[ci] Roll pinned nightly toolchain (#2442)

We remove `simd-nightly` impls for the `arm` target `[u]int8x4_t` types,
which are now just type aliases for `u32` and `i32`.

We also switch from using `wasm32-wasi` to `wasm32-unknown-unknown` in
CI, as the former is less supported (and not available via `rustup` on
this particular nightly).

gherrit-pr-id: I0a19a7789334f41ffedc55b871df9736d4b51484

Author: google-pr-creation-bot

.github/workflows/ci.yml

@@ -68,7 +68,7 @@ jobs:
           "s390x-unknown-linux-gnu",
           "x86_64-pc-windows-msvc",
           "thumbv6m-none-eabi",
-          "wasm32-wasi"
+          "wasm32-unknown-unknown"
         ]
         features: [
           "--no-default-features",
@@ -124,7 +124,7 @@ jobs:
           # Exclude stable/wasm since wasm is no longer provided via rustup on
           # stable.
           - toolchain: "stable"
-            target: "wasm32-wasi"
+            target: "wasm32-unknown-unknown"
           # Exclude non-aarch64 targets from the `zerocopy-aarch64-simd-1-59-0`
           # toolchain.
           - toolchain: "zerocopy-aarch64-simd-1-59-0"
@@ -146,7 +146,7 @@ jobs:
           - toolchain: "zerocopy-aarch64-simd-1-59-0"
             target: "thumbv6m-none-eabi"
           - toolchain: "zerocopy-aarch64-simd-1-59-0"
-            target: "wasm32-wasi"
+            target: "wasm32-unknown-unknown"
           # Exclude most targets targets from the `zerocopy-core-error-1-81-0`
           # toolchain since the `zerocopy-core-error-1-81-0` feature is unrelated to
           # compilation target. This only leaves i686 and x86_64 targets.
@@ -167,7 +167,7 @@ jobs:
           - toolchain: "zerocopy-core-error-1-81-0"
             target: "thumbv6m-none-eabi"
           - toolchain: "zerocopy-core-error-1-81-0"
-            target: "wasm32-wasi"
+            target: "wasm32-unknown-unknown"
           # Exclude most targets targets from the
           # `zerocopy-diagnostic-on-unimplemented-1-78-0` toolchain since the
           # `zerocopy-diagnostic-on-unimplemented-1-78-0` feature is unrelated to
@@ -189,7 +189,7 @@ jobs:
           - toolchain: "zerocopy-diagnostic-on-unimplemented-1-78-0"
             target: "thumbv6m-none-eabi"
           - toolchain: "zerocopy-diagnostic-on-unimplemented-1-78-0"
-            target: "wasm32-wasi"
+            target: "wasm32-unknown-unknown"
           # Exclude most targets targets from the
           # `zerocopy-generic-bounds-in-const-fn-1-61-0` toolchain since the
           # `zerocopy-generic-bounds-in-const-fn-1-61-0` feature is unrelated to
@@ -211,7 +211,7 @@ jobs:
           - toolchain: "zerocopy-generic-bounds-in-const-fn-1-61-0"
             target: "thumbv6m-none-eabi"
           - toolchain: "zerocopy-generic-bounds-in-const-fn-1-61-0"
-            target: "wasm32-wasi"
+            target: "wasm32-unknown-unknown"
           # Exclude `thumbv6m-none-eabi` combined with any feature that implies
           # the `std` feature since `thumbv6m-none-eabi` does not include a
           # pre-compiled std.
@@ -237,7 +237,7 @@ jobs:
             event_name: "pull_request"
           - target: "thumbv6m-none-eabi"
             event_name: "pull_request"
-          - target: "wasm32-wasi"
+          - target: "wasm32-unknown-unknown"
             event_name: "pull_request"
 
     name: Build & Test (${{ matrix.crate }} / ${{ matrix.toolchain }} / ${{ matrix.features }} / ${{ matrix.target }})
@@ -447,12 +447,12 @@ jobs:
       # Miri can catch any errors before a PR is merged into main.
       #
       # TODO(#22): Re-enable testing on riscv64gc-unknown-linux-gnu and/or
-      # wasm32-wasi once those work.
+      # wasm32-unknown-unknown once those work.
       if: |
         matrix.toolchain == 'nightly' &&
         matrix.target != 'riscv64gc-unknown-linux-gnu' &&
         matrix.target != 'thumbv6m-none-eabi' &&
-        matrix.target != 'wasm32-wasi' &&
+        matrix.target != 'wasm32-unknown-unknown' &&
         github.event_name != 'pull_request'
 
     # On the `thumbv6m-none-eabi` target, we can't run `cargo clippy --tests`
@@ -526,13 +526,12 @@ jobs:
         features: __internal_use_only_features_that_work_on_stable
         rust-toolchain: ${{ env.ZC_TOOLCHAIN }}
         rust-target: ${{ matrix.target }}
-      # TODO(#1565): Run on wasm32-wasi. As of this writing, this target fails:
-      # https://github.com/google/zerocopy/actions/runs/9944220377/job/27469879712
+      # TODO(#1565): Run on wasm32-unknown-unknown.
       if: |
         matrix.crate == 'zerocopy' &&
         matrix.features == '--features __internal_use_only_features_that_work_on_stable' &&
         matrix.toolchain == 'stable' &&
-        matrix.target != 'wasm32-wasi' &&
+        matrix.target != 'wasm32-unknown-unknown' &&
         env.ZC_SKIP_CARGO_SEMVER_CHECKS != '1'
 
     # TODO(#453): Doing this as a matrix step is a hack that allows us to depend

Cargo.toml

@@ -60,7 +60,7 @@ zerocopy-panic-in-const-and-vec-try-reserve-1-57-0 = "1.57.0"
 [package.metadata.ci]
 # The versions of the stable and nightly compiler toolchains to use in CI.
 pinned-stable = "1.85.0"
-pinned-nightly = "nightly-2024-11-06"
+pinned-nightly = "nightly-2025-03-17"
 
 [package.metadata.docs.rs]
 all-features = true

src/impls.rs

@@ -1127,10 +1127,6 @@ mod simd {
             uint8x16x2_t, uint8x16x3_t, uint8x16x4_t, uint16x4_t, uint16x8_t, uint32x2_t, uint32x4_t,
             uint64x1_t, uint64x2_t
         );
-        simd_arch_mod!(
-            #[cfg(all(feature = "simd-nightly", target_arch = "arm"))]
-            arm, arm, int8x4_t, uint8x4_t
-        );
     };
 }
 
@@ -2130,9 +2126,6 @@ mod tests {
                 uint8x16x2_t, uint8x16x3_t, uint8x16x4_t, uint16x4_t, uint16x8_t, uint32x2_t, uint32x4_t,
                 uint64x1_t, uint64x2_t
             );
-            #[cfg(all(feature = "simd-nightly", target_arch = "arm"))]
-            #[rustfmt::skip]
-            test_simd_arch_mod!(arm, int8x4_t, uint8x4_t);
         }
     }
 }

src/lib.rs

@@ -871,7 +871,7 @@ impl PointerMetadata for usize {
 
 // SAFETY: Delegates safety to `DstLayout::for_slice`.
 unsafe impl<T> KnownLayout for [T] {
-    #[allow(clippy::missing_inline_in_public_items)]
+    #[allow(clippy::missing_inline_in_public_items, dead_code)]
     #[cfg_attr(
         all(coverage_nightly, __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS),
         coverage(off)

src/pointer/inner.rs

@@ -39,7 +39,7 @@ mod _def {
         ///    byte range which is entirely contained in `A`.
         /// 3. `ptr` addresses a byte range whose length fits in an `isize`.
         /// 4. `ptr` addresses a byte range which does not wrap around the
-        ///     address space.
+        ///    address space.
         /// 5. If `ptr`'s referent is not zero sized,`A` is guaranteed to live
         ///    for at least `'a`.
         ptr: NonNull<T>,

src/util/macros.rs

@@ -150,7 +150,7 @@ macro_rules! unsafe_impl {
     };
 
     (@method TryFromBytes ; |$candidate:ident| $is_bit_valid:expr) => {
-        #[allow(clippy::missing_inline_in_public_items)]
+        #[allow(clippy::missing_inline_in_public_items, dead_code)]
         #[cfg_attr(all(coverage_nightly, __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS), coverage(off))]
         fn only_derive_is_allowed_to_implement_this_trait() {}
 
@@ -166,7 +166,7 @@ macro_rules! unsafe_impl {
         #[inline(always)] fn is_bit_valid<AA: crate::pointer::invariant::Reference>(_: Maybe<'_, Self, AA>) -> bool { true }
     };
     (@method $trait:ident) => {
-        #[allow(clippy::missing_inline_in_public_items)]
+        #[allow(clippy::missing_inline_in_public_items, dead_code)]
         #[cfg_attr(all(coverage_nightly, __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS), coverage(off))]
         fn only_derive_is_allowed_to_implement_this_trait() {}
     };
@@ -491,7 +491,7 @@ macro_rules! unsafe_impl_known_layout {
 
             #[allow(non_local_definitions)]
             unsafe impl<$($tyvar: ?Sized + KnownLayout)?> KnownLayout for $ty {
-                #[allow(clippy::missing_inline_in_public_items)]
+                #[allow(clippy::missing_inline_in_public_items, dead_code)]
                 #[cfg_attr(all(coverage_nightly, __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS), coverage(off))]
                 fn only_derive_is_allowed_to_implement_this_trait() {}
 

tests/ui-nightly/invalid-impls/invalid-impls.stderr

@@ -21,7 +21,7 @@ note: required by a bound in `_::Subtrait`
 26 | impl_or_verify!(T => TryFromBytes for Foo<T>);
    | --------------------------------------------- in this macro invocation
    = note: this error originates in the derive macro `FromBytes` which comes from the expansion of the macro `impl_or_verify` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: consider restricting type parameter `T`
+help: consider restricting type parameter `T` with trait `TryFromBytes`
    |
 26 | impl_or_verify!(T: zerocopy::TryFromBytes => TryFromBytes for Foo<T>);
    |                  ++++++++++++++++++++++++
@@ -49,7 +49,7 @@ note: required by a bound in `_::Subtrait`
 27 | impl_or_verify!(T => FromZeros for Foo<T>);
    | ------------------------------------------ in this macro invocation
    = note: this error originates in the derive macro `FromBytes` which comes from the expansion of the macro `impl_or_verify` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: consider restricting type parameter `T`
+help: consider restricting type parameter `T` with trait `FromZeros`
    |
 27 | impl_or_verify!(T: zerocopy::FromZeros => FromZeros for Foo<T>);
    |                  +++++++++++++++++++++
@@ -77,7 +77,7 @@ note: required by a bound in `_::Subtrait`
 28 | impl_or_verify!(T => FromBytes for Foo<T>);
    | ------------------------------------------ in this macro invocation
    = note: this error originates in the derive macro `FromBytes` which comes from the expansion of the macro `impl_or_verify` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: consider restricting type parameter `T`
+help: consider restricting type parameter `T` with trait `FromBytes`
    |
 28 | impl_or_verify!(T: zerocopy::FromBytes => FromBytes for Foo<T>);
    |                  +++++++++++++++++++++
@@ -105,7 +105,7 @@ note: required by a bound in `_::Subtrait`
 29 | impl_or_verify!(T => IntoBytes for Foo<T>);
    | ------------------------------------------ in this macro invocation
    = note: this error originates in the derive macro `IntoBytes` which comes from the expansion of the macro `impl_or_verify` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: consider restricting type parameter `T`
+help: consider restricting type parameter `T` with trait `IntoBytes`
    |
 29 | impl_or_verify!(T: zerocopy::IntoBytes => IntoBytes for Foo<T>);
    |                  +++++++++++++++++++++
@@ -133,7 +133,7 @@ note: required by a bound in `_::Subtrait`
 30 | impl_or_verify!(T => Unaligned for Foo<T>);
    | ------------------------------------------ in this macro invocation
    = note: this error originates in the derive macro `Unaligned` which comes from the expansion of the macro `impl_or_verify` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: consider restricting type parameter `T`
+help: consider restricting type parameter `T` with trait `Unaligned`
    |
 30 | impl_or_verify!(T: zerocopy::Unaligned => Unaligned for Foo<T>);
    |                  +++++++++++++++++++++

tests/ui-nightly/transmute-mut-const.stderr

@@ -13,7 +13,7 @@ note: `const` item defined here
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(const_item_mutation)]` on by default
 
-error[E0015]: cannot call non-const fn `transmute_mut::<'_, '_, [u8; 2], [u8; 2]>` in constants
+error[E0015]: cannot call non-const function `transmute_mut::<'_, '_, [u8; 2], [u8; 2]>` in constants
   --> tests/ui-nightly/transmute-mut-const.rs:20:37
    |
 20 | const CONST_CONTEXT: &mut [u8; 2] = transmute_mut!(&mut ARRAY_OF_U8S);

tests/ui-nightly/transmute-mut-dst-not-a-reference.stderr

@@ -53,7 +53,7 @@ help: the return type of this call is `&mut _` due to the type of the argument p
   --> tests/ui-nightly/transmute-mut-dst-not-a-reference.rs:17:36
    |
 17 | const DST_NOT_A_REFERENCE: usize = transmute_mut!(&mut 0u8);
-   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^ this argument influences the return type of `$crate`
+   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^ this argument influences the return type of `must_use`
 note: function defined here
   --> src/util/macro_util.rs
    |

tests/ui-nightly/transmute-mut-dst-unsized.stderr

@@ -48,9 +48,9 @@ error[E0277]: the size for values of type `[u8]` cannot be known at compilation
    |
    = help: the trait `Sized` is not implemented for `[u8]`
 note: required by an implicit `Sized` bound in `std::intrinsics::transmute`
-  --> $RUST/core/src/intrinsics.rs
+  --> $RUST/core/src/intrinsics/mod.rs
    |
-   | pub const unsafe fn transmute<Src, Dst>(_src: Src) -> Dst {
+   | pub const unsafe fn transmute<Src, Dst>(src: Src) -> Dst;
    |                                    ^^^ required by the implicit `Sized` requirement on this type parameter in `transmute`
    = note: this error originates in the macro `$crate::assert_size_eq` which comes from the expansion of the macro `transmute_mut` (in Nightly builds, run with -Z macro-backtrace for more info)