Fix broken dependencies in v29.0.0 of the client library (Issue #1092) by pinning those dependencies to an earlier version.

Author: Brothman

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 30.0.0
+*    Fixed the potential break in v29.0.0 (due to dependency conflicts) by pinning the protobuf dependency to be <=4.30.0 and reverting back to the old getLabel method.
+*    Fixed the potential maximum call size error due to a bug in the GRPC C extension by pinning ext-grpc to be <=1.66.0
+
 ## 29.0.0
 *    Security fixes, updated deprecated getLabel to isRepeated.
 

Dockerfile

@@ -15,10 +15,10 @@ RUN curl -sS https://getcomposer.org/installer | php
 RUN mv composer.phar /usr/local/bin/composer
 
 # Install and configure the gRPC extension.
-RUN pecl install grpc
+RUN pecl install grpc-1.66.0
 RUN echo 'extension=grpc.so' >> $PHP_INI_DIR/conf.d/grpc.ini
 
 # Install and configure the C implementation of Protobuf extension if needed.
-RUN if [ "$USE_C_PROTOBUF" = "false" ]; then echo 'Using PHP implementation of Protobuf'; else echo 'Using C implementation of Protobuf'; pecl install protobuf; echo 'extension=protobuf.so' >> $PHP_INI_DIR/conf.d/protobuf.ini; fi
+RUN if [ "$USE_C_PROTOBUF" = "false" ]; then echo 'Using PHP implementation of Protobuf'; else echo 'Using C implementation of Protobuf'; pecl install protobuf-4.30.0; echo 'extension=protobuf.so' >> $PHP_INI_DIR/conf.d/protobuf.ini; fi
 
 WORKDIR "/google-ads-php"

composer.json

@@ -6,15 +6,15 @@
     "php": ">=8.1",
     "google/gax": "^1.19.1",
     "grpc/grpc": "^1.36.0",
-    "google/protobuf": "^3.21.5 || ^4.26",
+    "google/protobuf": "3.21.5 || >=4.26 <=4.30.0",
     "monolog/monolog": "^1.26 || ^2.0 || ^3.0"
   },
   "require-dev": {
     "phpunit/phpunit": "^9.5",
     "squizlabs/php_codesniffer": "^3.5",
     "ext-bcmath": "*",
-    "ext-grpc": "*",
-    "ext-protobuf": "*",
+    "ext-grpc": ">=1.57.0 <=1.66.0",
+    "ext-protobuf": "3.21.5 || >=4.26 <=4.30.0",
     "ulrichsg/getopt-php": "^3.4",
     "react/http": "^1.2.0",
     "composer/composer": "^2.0"

src/Google/Ads/GoogleAds/Constants.php

@@ -27,5 +27,5 @@ class Constants
     public const LIBRARY_NAME = 'gccl';
 
     // The library version.
-    public const LIBRARY_VERSION = '29.0.0';
+    public const LIBRARY_VERSION = '30.0.0';
 }

src/Google/Ads/GoogleAds/Util/FieldMasks.php

@@ -353,7 +353,7 @@ private static function getDescriptorForMessage(Message $message)
      */
     private static function isFieldRepeated(FieldDescriptor $fieldDescriptor)
     {
-        return $fieldDescriptor->isRepeated();
+        return $fieldDescriptor->getLabel() === GPBLabel::REPEATED;
     }
 
     // TODO: We can remove this function when it's supported in google/gax-php: