Changes for Q12025 Release (#915)

Migrate setup.py file to a pyproject.toml file
Add support for Python 3.13 and remove support for 3.8
Fix bug in upload_offline_conversion example.
Update library to support default gapic templates.
Regen v17, v18, and v19 with default templates. Remove v16.

Author: BenRKarl

CONTRIBUTING.md

@@ -43,14 +43,14 @@ You can manually run the formatter on all non-generated code with the following
 command:
 
 ```
-python -m black -l 80 -t py37 --exclude "/(v[0-9]+|\.eggs|\.git|_cache|\.nox|\.tox|\.venv|\.svn|_build|buck-out|build|dist)/" .
+python -m black -l 80 --exclude "/(v[0-9]+|\.eggs|\.git|_cache|\.nox|\.tox|\.venv|\.svn|_build|buck-out|build|dist)/" .
 ```
 
 Alternatively, if you intend to contribute regularly, it might be easier to
 append this script to the `.git/hooks/pre-commit` file:
 
 ```
 FILES=$(git diff --cached --name-only --diff-filter=ACMR "*.py" | grep -v "google/ads/google_ads/v.*")
-echo "${FILES}" | xargs python -m black -l 80 -t py37
+echo "${FILES}" | xargs python -m black -l 80
 echo "${FILES}" | xargs git add
 ```

ChangeLog

@@ -1,3 +1,10 @@
+* 26.0.0
+- Migrate to default GAPIC templates
+- Migrate from setup.py to pyproject.toml
+- Remove Google Ads API v16
+- Add support for Python 3.13
+- Remove support for Python 3.8
+
 * 25.2.0
 - Google Ads API v19 release.
 

examples/remarketing/upload_offline_conversion.py

@@ -134,6 +134,10 @@ def main(
 
 
 if __name__ == "__main__":
+    # GoogleAdsClient will read the google-ads.yaml configuration file in the
+    # home directory if none is specified.
+    googleads_client = GoogleAdsClient.load_from_storage(version="v19")
+
     parser = argparse.ArgumentParser(
         description="Uploads an offline conversion."
     )
@@ -225,10 +229,6 @@ def main(
     )
     args = parser.parse_args()
 
-    # GoogleAdsClient will read the google-ads.yaml configuration file in the
-    # home directory if none is specified.
-    googleads_client = GoogleAdsClient.load_from_storage(version="v19")
-
     try:
         main(
             googleads_client,

google/ads/googleads/__init__.py

@@ -19,12 +19,4 @@
 import google.ads.googleads.errors
 import google.ads.googleads.util
 
-VERSION = "25.2.0"
-
-if sys.version_info.major == 3 and sys.version_info.minor <= 8:
-    warnings.warn(
-        "Python versions 3.8 and below will soon be deprecated in the "
-        "google-ads package. Please upgrade to Python 3.9 or higher as soon as "
-        "possible.",
-        category=DeprecationWarning,
-    )
+VERSION = "26.0.0"

google/ads/googleads/client.py

@@ -31,7 +31,8 @@
 
 _SERVICE_CLIENT_TEMPLATE = "{}Client"
 
-_VALID_API_VERSIONS = ["v19", "v18", "v17", "v16"]
+_VALID_API_VERSIONS = ["v19", "v18", "v17"]
+_MESSAGE_TYPES = ["common", "enums", "errors", "resources", "services"]
 _DEFAULT_VERSION = _VALID_API_VERSIONS[0]
 
 # Retrieve the version of this client library to be sent in the user-agent
@@ -357,14 +358,17 @@ def get_service(self, name, version=_DEFAULT_VERSION, interceptors=None):
         # If version is specified when the instance is created,
         # override any version specified as an argument.
         version = self.version if self.version else version
-        api_module = self._get_api_services_by_version(version)
+        # api_module = self._get_api_services_by_version(version)
+        services_path = f"google.ads.googleads.{version}.services.services"
+        snaked = util.convert_upper_case_to_snake_case(name)
         interceptors = interceptors or []
 
         try:
-            service_client_class = getattr(
-                api_module, _SERVICE_CLIENT_TEMPLATE.format(name)
+            service_module = import_module(f"{services_path}.{snaked}")
+            service_client_class = util.get_nested_attr(
+                service_module, _SERVICE_CLIENT_TEMPLATE.format(name)
             )
-        except AttributeError:
+        except (AttributeError, ModuleNotFoundError):
             raise ValueError(
                 'Specified service {}" does not exist in Google '
                 "Ads API {}.".format(name, version)
@@ -438,17 +442,25 @@ def get_type(self, name, version=_DEFAULT_VERSION):
         # If version is specified when the instance is created,
         # override any version specified as an argument.
         version = self.version if self.version else version
+        type_classes = self._get_api_services_by_version(version)
 
-        try:
-            type_classes = self._get_api_services_by_version(version)
-            message_class = getattr(type_classes, name)
-        except AttributeError:
-            raise ValueError(
-                f"Specified type '{name}' does not exist in "
-                f"Google Ads API {version}"
-            )
+        for type in _MESSAGE_TYPES:
+            if type == "services":
+                path = f"{type}.types.{name}"
+            else:
+                path = f"{type}.{name}"
 
-        if self.use_proto_plus == True:
-            return message_class()
-        else:
-            return util.convert_proto_plus_to_protobuf(message_class())
+            try:
+                message_class = util.get_nested_attr(type_classes, path)
+
+                if self.use_proto_plus == True:
+                    return message_class()
+                else:
+                    return util.convert_proto_plus_to_protobuf(message_class())
+            except AttributeError:
+                pass
+
+        raise ValueError(
+            f"Specified type '{name}' does not exist in "
+            f"Google Ads API {version}"
+        )