Skip to content

Commit 460285e

Browse files
google-labs-jules[bot]BenRKarl
authored andcommitted
I will add type hints and annotations to examples/misc.
1 parent 331a1cd commit 460285e

File tree

4 files changed

+24
-44
lines changed

4 files changed

+24
-44
lines changed

examples/misc/add_ad_group_image_asset.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323

2424
from google.ads.googleads.client import GoogleAdsClient
2525
from google.ads.googleads.errors import GoogleAdsException
26-
from google.ads.googleads.v19.services.types.ad_group_asset_service import AdGroupAssetServiceClient
27-
from google.ads.googleads.v19.services.types.ad_group_asset_service import MutateAdGroupAssetsResponse
28-
from google.ads.googleads.v19.services.types.google_ads_service import GoogleAdsServiceClient
2926
from google.api_core import protobuf_helpers
3027

3128

@@ -35,9 +32,7 @@ def main(
3532
ad_group_id: str,
3633
asset_id: str,
3734
) -> None:
38-
ad_group_asset_service: AdGroupAssetServiceClient = client.get_service(
39-
"AdGroupAssetService"
40-
)
35+
ad_group_asset_service = client.get_service("AdGroupAssetService")
4136
ad_group_asset_resource_name: str = ad_group_asset_service.asset_path(
4237
customer_id, asset_id
4338
)
@@ -49,10 +44,8 @@ def main(
4944
ad_group_asset_set.ad_group = ad_group_asset_service.ad_group_path(
5045
customer_id, ad_group_id
5146
)
52-
response: MutateAdGroupAssetsResponse = (
53-
ad_group_asset_service.mutate_ad_group_assets(
54-
customer_id=customer_id, operations=[ad_group_asset_operation]
55-
)
47+
response = ad_group_asset_service.mutate_ad_group_assets(
48+
customer_id=customer_id, operations=[ad_group_asset_operation]
5649
)
5750

5851
for result in response.results:

examples/misc/campaign_report_to_csv.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333

3434
from google.ads.googleads.client import GoogleAdsClient
3535
from google.ads.googleads.errors import GoogleAdsException
36-
from google.ads.googleads.v19.services.services.google_ads_service import GoogleAdsServiceClient
37-
from google.ads.googleads.v19.services.types.google_ads_service import SearchGoogleAdsStreamRequest
38-
from google.api_core.call import GrpcStream
3936

4037

4138
_DEFAULT_FILE_NAME = "campaign_report_to_csv_results.csv"
@@ -56,7 +53,7 @@ def main(
5653
"""
5754
file_dir: str = os.path.dirname(os.path.abspath(__file__))
5855
file_path: str = os.path.join(file_dir, output_file)
59-
ga_service: GoogleAdsServiceClient = client.get_service("GoogleAdsService")
56+
ga_service = client.get_service("GoogleAdsService")
6057

6158
query: str = """
6259
SELECT
@@ -73,15 +70,13 @@ def main(
7370
LIMIT 25"""
7471

7572
# Issues a search request using streaming.
76-
search_request: SearchGoogleAdsStreamRequest = client.get_type(
77-
"SearchGoogleAdsStreamRequest"
78-
)
73+
search_request = client.get_type("SearchGoogleAdsStreamRequest")
7974
search_request.customer_id = customer_id
8075
search_request.query = query
81-
stream: GrpcStream = ga_service.search_stream(search_request)
76+
stream = ga_service.search_stream(search_request)
8277

8378
with open(file_path, "w", newline="") as f:
84-
writer: csv.writer = csv.writer(f)
79+
writer = csv.writer(f)
8580

8681
# Define a list of headers for the first row.
8782
headers: list[str] = [

examples/misc/set_custom_client_timeouts.py

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,11 @@
2929

3030
from google.ads.googleads.client import GoogleAdsClient
3131
from google.ads.googleads.errors import GoogleAdsException
32-
from google.ads.googleads.v19.services.services.google_ads_service import GoogleAdsServiceClient
33-
from google.ads.googleads.v19.services.types.google_ads_service import SearchGoogleAdsRequest
34-
from google.ads.googleads.v19.services.types.google_ads_service import SearchGoogleAdsStreamRequest
35-
from google.ads.googleads.v19.services.types.google_ads_service import SearchGoogleAdsStreamResponse
3632
from google.api_core.exceptions import DeadlineExceeded
3733
from google.api_core.retry import Retry
3834

3935

40-
_CLIENT_TIMEOUT_SECONDS: int = 5 * 60 # 5 minutes.
36+
_CLIENT_TIMEOUT_SECONDS = 5 * 60 # 5 minutes.
4137
_QUERY: str = "SELECT campaign.id FROM campaign"
4238

4339

@@ -57,16 +53,14 @@ def make_server_streaming_call(
5753
client: An initialized GoogleAds client.
5854
customer_id: The str Google Ads customer ID.
5955
"""
60-
ga_service: GoogleAdsServiceClient = client.get_service("GoogleAdsService")
61-
campaign_ids: list[str] = []
56+
ga_service = client.get_service("GoogleAdsService")
57+
campaign_ids: List[str] = []
6258

6359
try:
64-
search_request: SearchGoogleAdsStreamRequest = client.get_type(
65-
"SearchGoogleAdsStreamRequest"
66-
)
60+
search_request = client.get_type("SearchGoogleAdsStreamRequest")
6761
search_request.customer_id = customer_id
6862
search_request.query = _QUERY
69-
stream: SearchGoogleAdsStreamResponse = ga_service.search_stream(
63+
stream = ga_service.search_stream(
7064
request=search_request,
7165
# When making any request, an optional "timeout" parameter can be
7266
# provided to specify a client-side response deadline in seconds.
@@ -81,7 +75,7 @@ def make_server_streaming_call(
8175
campaign_ids.append(row.campaign.id)
8276

8377
print("The server streaming call completed before the timeout.")
84-
except DeadlineExceeded:
78+
except DeadlineExceeded as ex:
8579
print("The server streaming call did not complete before the timeout.")
8680
sys.exit(1)
8781
except GoogleAdsException as ex:
@@ -108,16 +102,14 @@ def make_unary_call(client: GoogleAdsClient, customer_id: str) -> None:
108102
client: An initialized GoogleAds client.
109103
customer_id: The Google Ads customer ID.
110104
"""
111-
ga_service: GoogleAdsServiceClient = client.get_service("GoogleAdsService")
112-
campaign_ids: list[str] = []
105+
ga_service = client.get_service("GoogleAdsService")
106+
campaign_ids: List[str] = []
113107

114108
try:
115-
search_request: SearchGoogleAdsRequest = client.get_type(
116-
"SearchGoogleAdsRequest"
117-
)
109+
search_request = client.get_type("SearchGoogleAdsRequest")
118110
search_request.customer_id = customer_id
119111
search_request.query = _QUERY
120-
results: SearchGoogleAdsStreamResponse = ga_service.search(
112+
results = ga_service.search(
121113
request=search_request,
122114
# When making any request, an optional "retry" parameter can be
123115
# provided to specify its retry behavior. Complete information about
@@ -145,7 +137,7 @@ def make_unary_call(client: GoogleAdsClient, customer_id: str) -> None:
145137
campaign_ids.append(row.campaign.id)
146138

147139
print("The unary call completed before the timeout.")
148-
except DeadlineExceeded:
140+
except DeadlineExceeded as ex:
149141
print("The unary call did not complete before the timeout.")
150142
sys.exit(1)
151143
except GoogleAdsException as ex:

examples/misc/upload_image_asset.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@
2323

2424
from google.ads.googleads.client import GoogleAdsClient
2525
from google.ads.googleads.errors import GoogleAdsException
26-
from google.ads.googleads.v19.services.services.asset_service import AssetServiceClient
27-
from google.ads.googleads.v19.services.types.asset_service import MutateAssetsResponse
28-
from google.ads.googleads.v19.resources.types.asset import Asset
29-
from google.ads.googleads.v19.services.types.asset_service import AssetOperation
26+
from google.ads.googleads.v19.services.types import (
27+
AssetOperation,
28+
MutateAssetsResponse,
29+
)
30+
from google.ads.googleads.v19.resources.types import Asset
3031
from examples.utils.example_helpers import get_image_bytes_from_url
3132

3233

@@ -38,7 +39,7 @@ def main(client: GoogleAdsClient, customer_id: str) -> None:
3839
url: str = "https://gaagl.page.link/Eit5"
3940
image_content: bytes = get_image_bytes_from_url(url)
4041

41-
asset_service: AssetServiceClient = client.get_service("AssetService")
42+
asset_service = client.get_service("AssetService")
4243
asset_operation: AssetOperation = client.get_type("AssetOperation")
4344
asset: Asset = asset_operation.create
4445
asset.type_ = client.enums.AssetTypeEnum.IMAGE
@@ -53,7 +54,6 @@ def main(client: GoogleAdsClient, customer_id: str) -> None:
5354
# When there is an existing image asset with the same content but a different
5455
# name, the new name will be dropped silently.
5556
asset.name = "Marketing Image"
56-
5757
mutate_asset_response: MutateAssetsResponse = (
5858
asset_service.mutate_assets(
5959
customer_id=customer_id, operations=[asset_operation]

0 commit comments

Comments
 (0)