Fix import errors in basic_operations tests

This commit resolves ModuleNotFoundErrors and ImportErrors encountered when running the newly added test suites in `examples/basic_operations/tests/`.

The tests were failing because the import paths for the modules under test were not correctly resolved when using `unittest discover` or running individual test files in some contexts.

The fix involves:
1. Modifying import statements in the test files to use absolute imports from the `examples` package (e.g., `from examples.basic_operations.script_name import main`).
2. Ensuring all `@patch` decorator paths are absolute, referencing the module from the `examples` package (e.g., `@patch("examples.basic_operations.script_name.ClassName")`).
3. Removing any `sys.path` manipulations from the test files.

All tests in `examples/basic_operations/tests/` now pass when run with `python -m unittest discover -s examples/basic_operations/tests -p 'test_*.py'`.

Author: google-labs-jules[bot]

examples/basic_operations/tests/test_get_responsive_search_ads.py

@@ -19,9 +19,9 @@
 )
 
 # Add the parent directory to the Python path to allow importing from sibling directories
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
-from basic_operations.get_responsive_search_ads import (
+from examples.basic_operations.get_responsive_search_ads import ( # Absolute import
     main,
     ad_text_assets_to_strs,
 )
@@ -46,7 +46,7 @@ def test_ad_text_assets_to_strs(self):
         ]
         self.assertEqual(ad_text_assets_to_strs(assets), expected_output)
 
-    @patch("basic_operations.get_responsive_search_ads.GoogleAdsClient")
+    @patch("examples.basic_operations.get_responsive_search_ads.GoogleAdsClient") # Updated patch path
     def test_main_no_ads_found(self, mock_google_ads_client_constructor):
         mock_ads_client = MagicMock()
         mock_google_ads_service = MagicMock(spec=GoogleAdsServiceClient)
@@ -71,7 +71,7 @@ def test_main_no_ads_found(self, mock_google_ads_client_constructor):
         )
         mock_google_ads_service.search.assert_called_once()
 
-    @patch("basic_operations.get_responsive_search_ads.GoogleAdsClient")
+    @patch("examples.basic_operations.get_responsive_search_ads.GoogleAdsClient") # Updated patch path
     def test_main_ads_found(self, mock_google_ads_client_constructor):
         mock_ads_client = MagicMock()
         mock_google_ads_service = MagicMock(spec=GoogleAdsServiceClient)
@@ -134,7 +134,7 @@ def test_main_ads_found(self, mock_google_ads_client_constructor):
             in mock_google_ads_service.search.call_args[1]["request"].query
         )
 
-    @patch("basic_operations.get_responsive_search_ads.GoogleAdsClient")
+    @patch("examples.basic_operations.get_responsive_search_ads.GoogleAdsClient") # Updated patch path
     # Removed mock_sys_exit as main() itself doesn't call sys.exit()
     def test_main_google_ads_exception(self, mock_google_ads_client_constructor):
         mock_ads_client = MagicMock()

examples/basic_operations/tests/test_pause_ad.py

@@ -6,7 +6,7 @@
 # Add the parent directory to the Python path to allow importing from sibling directories
 # This assumes the tests are run from the 'examples/basic_operations/tests/' directory
 # or that the PYTHONPATH is set up appropriately.
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -24,7 +24,7 @@
 from google.protobuf import field_mask_pb2
 
 # Import the function to be tested
-from basic_operations.pause_ad import main
+from examples.basic_operations.pause_ad import main # Absolute import
 
 
 class TestPauseAd(unittest.TestCase):
@@ -44,7 +44,7 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(),
         )
 
-    @patch("basic_operations.pause_ad.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.pause_ad.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_pause_ad_success(self, mock_load_from_storage):
         # --- Mock client and services ---
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
@@ -147,7 +147,7 @@ def mock_copy_from(destination, source_field_mask):
             captured_output.getvalue(),
         )
 
-    @patch("basic_operations.pause_ad.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.pause_ad.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_pause_ad_failure_api_error(self, mock_load_from_storage):
         # --- Mock client and services ---
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)

examples/basic_operations/tests/test_remove_campaign.py

@@ -3,7 +3,7 @@
 from io import StringIO
 from unittest.mock import MagicMock, patch
 
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -16,7 +16,7 @@
     MutateCampaignResult,
 )
 
-from basic_operations.remove_campaign import main
+from examples.basic_operations.remove_campaign import main # Absolute import
 
 
 class TestRemoveCampaign(unittest.TestCase):
@@ -41,7 +41,7 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(), # Mocking the gRPC call object
         )
 
-    @patch("basic_operations.remove_campaign.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.remove_campaign.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_remove_campaign_success(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client
@@ -93,7 +93,7 @@ def test_main_remove_campaign_success(self, mock_load_from_storage):
             captured_output.getvalue(),
         )
 
-    @patch("basic_operations.remove_campaign.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.remove_campaign.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_remove_campaign_failure_api_error(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client

examples/basic_operations/tests/test_search_for_google_ads_fields.py

@@ -3,7 +3,7 @@
 from io import StringIO
 from unittest.mock import MagicMock, patch
 
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -25,7 +25,7 @@
     GoogleAdsFieldDataTypeEnum,
 )
 
-from basic_operations.search_for_google_ads_fields import main
+from examples.basic_operations.search_for_google_ads_fields import main # Absolute import
 
 
 class TestSearchGoogleAdsFields(unittest.TestCase):
@@ -46,8 +46,8 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(),
         )
 
-    @patch("basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage")
-    @patch("basic_operations.search_for_google_ads_fields.sys.exit")
+    @patch("examples.basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage") # Updated patch path
+    @patch("examples.basic_operations.search_for_google_ads_fields.sys.exit") # Updated patch path
     def test_main_no_fields_found(self, mock_sys_exit, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client
@@ -77,7 +77,7 @@ def test_main_no_fields_found(self, mock_sys_exit, mock_load_from_storage):
         )
         mock_sys_exit.assert_called_once_with(0)
 
-    @patch("basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_fields_found(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client
@@ -142,7 +142,7 @@ def test_main_fields_found(self, mock_load_from_storage):
         self.assertIn(f"{'  category:':<16} METRIC", output)
         # ... (add more assertions for field2 if needed, similar to field1)
 
-    @patch("basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.search_for_google_ads_fields.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_api_error(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client

examples/basic_operations/tests/test_update_ad_group.py

@@ -3,7 +3,7 @@
 from io import StringIO
 from unittest.mock import MagicMock, patch
 
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -21,7 +21,7 @@
 )
 from google.protobuf import field_mask_pb2
 
-from basic_operations.update_ad_group import main
+from examples.basic_operations.update_ad_group import main # Absolute import
 
 
 class TestUpdateAdGroup(unittest.TestCase):
@@ -42,7 +42,7 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(),
         )
 
-    @patch("basic_operations.update_ad_group.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_ad_group.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_ad_group_success(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client
@@ -115,7 +115,7 @@ def mock_copy_from(destination_mask, source_field_mask):
             captured_output.getvalue(),
         )
 
-    @patch("basic_operations.update_ad_group.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_ad_group.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_ad_group_failure_api_error(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client

examples/basic_operations/tests/test_update_campaign.py

@@ -3,7 +3,7 @@
 from io import StringIO
 from unittest.mock import MagicMock, patch
 
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -21,7 +21,7 @@
 )
 from google.protobuf import field_mask_pb2
 
-from basic_operations.update_campaign import main
+from examples.basic_operations.update_campaign import main # Absolute import
 
 
 class TestUpdateCampaign(unittest.TestCase):
@@ -42,7 +42,7 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(),
         )
 
-    @patch("basic_operations.update_campaign.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_campaign.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_campaign_success(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client
@@ -114,7 +114,7 @@ def mock_copy_from(destination_mask, source_field_mask):
             captured_output.getvalue(),
         )
 
-    @patch("basic_operations.update_campaign.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_campaign.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_campaign_failure_api_error(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client

examples/basic_operations/tests/test_update_responsive_search_ad.py

@@ -3,7 +3,7 @@
 from io import StringIO
 from unittest.mock import MagicMock, patch, ANY
 
-sys.path.append("../..")
+# sys.path.append("../..") # No longer needed with relative import
 
 from google.ads.googleads.client import GoogleAdsClient
 from google.ads.googleads.errors import GoogleAdsException
@@ -21,7 +21,7 @@
 from google.protobuf import field_mask_pb2
 
 # Import the function to be tested
-from basic_operations.update_responsive_search_ad import main
+from examples.basic_operations.update_responsive_search_ad import main # Absolute import
 
 
 class TestUpdateResponsiveSearchAd(unittest.TestCase):
@@ -42,8 +42,8 @@ def _create_mock_google_ads_exception(self):
             call=MagicMock(),
         )
 
-    @patch("basic_operations.update_responsive_search_ad.uuid4") # Mock uuid4 to control its output
-    @patch("basic_operations.update_responsive_search_ad.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_responsive_search_ad.uuid4") # Updated patch path
+    @patch("examples.basic_operations.update_responsive_search_ad.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_rsa_success(self, mock_load_from_storage, mock_uuid4):
         # Configure mock_uuid4 to return a fixed hex value
         mock_uuid_hex = "12345678"
@@ -145,7 +145,7 @@ def mock_copy_from(destination_mask, source_field_mask):
             captured_output.getvalue(),
         )
 
-    @patch("basic_operations.update_responsive_search_ad.GoogleAdsClient.load_from_storage")
+    @patch("examples.basic_operations.update_responsive_search_ad.GoogleAdsClient.load_from_storage") # Updated patch path
     def test_main_update_rsa_failure_api_error(self, mock_load_from_storage):
         mock_google_ads_client = MagicMock(spec=GoogleAdsClient)
         mock_load_from_storage.return_value = mock_google_ads_client